From owner-svn-src-head@FreeBSD.ORG Mon Aug 26 09:43:38 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C9ADF88B; Mon, 26 Aug 2013 09:43:38 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5215A2D8B; Mon, 26 Aug 2013 09:43:37 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id r7Q9hTiA059394; Mon, 26 Aug 2013 13:43:29 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id r7Q9hTK1059393; Mon, 26 Aug 2013 13:43:29 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 26 Aug 2013 13:43:29 +0400 From: Gleb Smirnoff To: Andre Oppermann Subject: Re: svn commit: r254527 - in head/sys: net80211 netinet sys Message-ID: <20130826094329.GP4574@glebius.int.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Aug 2013 09:43:38 -0000 A> Author: andre A> Date: Mon Aug 19 14:25:11 2013 A> New Revision: 254527 A> URL: http://svnweb.freebsd.org/changeset/base/254527 A> A> Log: A> Reorder the mbuf defines to make more sense and group related flags A> together. A> A> Add M_FLAG_PRINTF for use with printf(9) %b indentifier. A> A> Use the generic mbuf flags print names in the net80211 code and adjust A> the protocol specific bits for their new positions. A> A> Change SCTP M_PROTO mapping from 5 to 1 to fit within the 16bit field A> they use internally to store some additional information. A> A> Discussed with: trociny, glebius The first part: "reorder the mbuf flag defines" wasn't actually discussed. Tossing values of M_BCAST, M_MCAST, M_VLANTAG for no value except code tidyness isn't a safe idea. These are the flags that device drivers use. After this change binary drivers are still loadable but would be buggy. We allow ourselves ABI changes in head, but this doesn't mean that we should do them for no important reason. -- Totus tuus, Glebius.