From owner-freebsd-multimedia@FreeBSD.ORG Thu Sep 8 14:33:04 2011 Return-Path: Delivered-To: multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BA0D1065670 for ; Thu, 8 Sep 2011 14:33:04 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-vw0-f50.google.com (mail-vw0-f50.google.com [209.85.212.50]) by mx1.freebsd.org (Postfix) with ESMTP id 35B648FC13 for ; Thu, 8 Sep 2011 14:33:03 +0000 (UTC) Received: by vws14 with SMTP id 14so1960vws.37 for ; Thu, 08 Sep 2011 07:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:from:date:message-id:subject:to:content-type; bh=ofPCXoAAHrTkCbq+N7Rqj3iylZRB3pDu6NdVq2x9o8M=; b=bjn3my3Nlb9X0q9MhDE0j/bwX+4oyRFQpAG9LoFz5nd7EpHnefVnq33AML/avDC3GJ wFkgc/KEBo94S87tIcBO11pIRvY+pYA1u6ffBsV5luQLTqPAo9EWFmm7VkO/4IUFlJVf ZukoyWwowPIOLuRoKnxCluYTlFPlDNuXQe1f4= Received: by 10.52.108.66 with SMTP id hi2mr774051vdb.243.1315490874399; Thu, 08 Sep 2011 07:07:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.180.72 with HTTP; Thu, 8 Sep 2011 07:07:24 -0700 (PDT) From: Eitan Adler Date: Thu, 8 Sep 2011 10:07:24 -0400 Message-ID: To: multimedia@freebsd.org Content-Type: text/plain; charset=UTF-8 Cc: Subject: [patch] multimedia/mjpegtools build failure, implicit dependency issue X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2011 14:33:04 -0000 Hi, A user reported to me some problems with the multimedia/mjpegtools port. 1) ports/157885 results in an ICE with optimizations enabled 2) The port does not explicitly disable SDL when WITHOUT_SDL is requested. Here is a patch that fixes these issues. Index: Makefile =================================================================== RCS file: /home/ncvs/ports/multimedia/mjpegtools/Makefile,v retrieving revision 1.74 diff -u -r1.74 Makefile --- Makefile 2 Jul 2011 19:59:19 -0000 1.74 +++ Makefile 8 Sep 2011 13:16:36 -0000 @@ -30,7 +30,9 @@ WANT_SDL= yes USE_GMAKE= yes USE_AUTOTOOLS= libtool +CFLAGS= -O0 CONFIGURE_ENV= LDFLAGS="${LDFLAGS}" \ + CFLAGS="${CFLAGS}" \ PTHREAD_CFLAGS="${PTHREAD_CFLAGS}" \ PTHREAD_LIBS="${PTHREAD_LIBS}" \ ac_cv_lib_Xxf86dga_XF86DGAQueryExtension=no @@ -70,6 +72,7 @@ .if defined(WITHOUT_SDL) CONFIGURE_ENV+= ac_cv_path_SDL_CONFIG=no +CONFIGURE_ARGS+=--without-libsdl PLIST_SUB+= SDL:="@comment " .else USE_SDL+= gfx sdl -- Eitan Adler