From owner-cvs-all@FreeBSD.ORG  Tue Jan 22 01:51:10 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 106DD16A421;
	Tue, 22 Jan 2008 01:51:10 +0000 (UTC)
	(envelope-from rafan@svm.csie.ntu.edu.tw)
Received: from svm.csie.ntu.edu.tw (svm.csie.ntu.edu.tw [140.112.90.75])
	by mx1.freebsd.org (Postfix) with ESMTP id 9B82A13C465;
	Tue, 22 Jan 2008 01:51:09 +0000 (UTC)
	(envelope-from rafan@svm.csie.ntu.edu.tw)
Received: from svm.csie.ntu.edu.tw (localhost [127.0.0.1])
	by svm.csie.ntu.edu.tw (8.14.1/8.14.1) with ESMTP id m0M1p8xT051676;
	Tue, 22 Jan 2008 09:51:08 +0800 (CST)
	(envelope-from rafan@svm.csie.ntu.edu.tw)
Received: (from rafan@localhost)
	by svm.csie.ntu.edu.tw (8.14.1/8.14.1/Submit) id m0M1p8vk078952;
	Tue, 22 Jan 2008 09:51:08 +0800 (CST) (envelope-from rafan)
Date: Tue, 22 Jan 2008 09:51:08 +0800
From: Rong-En Fan <rafan@FreeBSD.org>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20080122015108.GX4650@svm.csie.ntu.edu.tw>
References: <200801200837.m0K8bNX0081391@repoman.freebsd.org>
	<4795044E.6030006@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4795044E.6030006@FreeBSD.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, Rong-En Fan <rafan@FreeBSD.org>,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/sysutils/LPRng Makefile distinfo pkg-descr
	pkg-plist ports/sysutils/LPRng/files lprng.in pkg-message.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jan 2008 01:51:10 -0000

On Mon, Jan 21, 2008 at 12:45:02PM -0800, Doug Barton wrote:
> Rong-En Fan wrote:
>> rafan       2008-01-20 08:37:23 UTC
>> 
>>   FreeBSD ports repository
>> 
>>   Modified files:
>>     sysutils/LPRng       Makefile distinfo pkg-descr pkg-plist     
>> sysutils/LPRng/files pkg-message.in   Added files:
>>     sysutils/LPRng/files lprng.in   Log:
>>   - Update to 3.8.32
>>   - Provide new rc script
> 
> The script looks good, thanks for doing this! The only thing I would point 
> out is that the default _enable=no is not needed, since rc.subr needs to 
> see one of the values for "yes" in order to do anything. No harm leaving it 
> in, I just wanted to point out that it's not strictly necessary.

Thanks. I see most of our /etc/rc.d/* scripts does not have this.
But most ports' have as our Porter's Handbook have such example.

Regards,
Rong-En Fan-

> 
> Doug
> 
> -- 
> 
>     This .signature sanitized for your protection