From owner-freebsd-ports@FreeBSD.ORG Sat Dec 17 16:48:07 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED7D6106564A; Sat, 17 Dec 2011 16:48:07 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id AA7898FC18; Sat, 17 Dec 2011 16:48:07 +0000 (UTC) Received: by iadj38 with SMTP id j38so3042468iad.13 for ; Sat, 17 Dec 2011 08:48:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=+1rbDhJTy/I7NdZ5jNOF64fWp1dYS980ksh9sfgrobM=; b=nKmqjkW5+c0HiVCfSiOE66h+nlDuSS/TE4xRjGOpGKl8fKYgFbU6/gsO904tGJEf+g zN5jTzexSA5nJSfWWmT9k0MuheHeRhfDURN8bHI8VWBm2RP/f6TovgEQLeSJQXPDGcgp rAWjhmVBpklsGT6zwupJWQvhZpT77D/u1TR0c= Received: by 10.50.87.167 with SMTP id az7mr16383022igb.64.1324140486250; Sat, 17 Dec 2011 08:48:06 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.199.18 with HTTP; Sat, 17 Dec 2011 08:47:35 -0800 (PST) In-Reply-To: <1RbxBi-0008Ls-5O@internal.tormail.net> References: <1RbxBi-0008Ls-5O@internal.tormail.net> From: Chris Rees Date: Sat, 17 Dec 2011 16:47:35 +0000 X-Google-Sender-Auth: 2N8zOJAR2JyyxfbYZaW4S3fegEU Message-ID: To: Jan Beich Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Christer Solskogen , garga@freebsd.org, freebsd-ports Subject: Re: Removal of use_gmake breaks lua X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2011 16:48:08 -0000 On 17 December 2011 16:32, Jan Beich wrote: > Chris Rees writes: > >>> as seen here: >>> http://docs.freebsd.org/cgi/getmsg.cgi?fetch=3D295602+0+/usr/local/www/= db/text/2011/cvs-all/20111113.cvs-all >> >> I don't like the proposed solution; it's less hackish to just use >> gmake again; most people have it installed anyway.... > > A non-hackish solution would involve fixing sys.mk to guard against > recursive inclusion of __MAKE_CONF. bsd.port.mk is known to have > this when using make(1) for do-build. > > Not that I mind shoving the issue under the carpet by using gmake. > > Index: share/mk/sys.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- share/mk/sys.mk =A0 =A0 (revision 228500) > +++ share/mk/sys.mk =A0 =A0 (working copy) > @@ -306,10 +306,13 @@ YFLAGS =A0 =A0 =A0 =A0 =A0 =A0?=3D =A0 =A0 =A0-d > =A0 =A0 =A0 =A0${CTFCONVERT_CMD} > > =A0# FreeBSD build pollution. =A0Hide it in the non-POSIX part of the ifd= ef. > +.if !defined(__MAKE_CONF_INCLUDED) > +__MAKE_CONF_INCLUDED=3D > =A0__MAKE_CONF?=3D/etc/make.conf > =A0.if exists(${__MAKE_CONF}) > =A0.include "${__MAKE_CONF}" > =A0.endif > +.endif > > =A0.if defined(__MAKE_SHELL) && !empty(__MAKE_SHELL) > =A0SHELL=3D ${__MAKE_SHELL} Ah now there is a better solution :) I'll see if we can get it in the tree. Thanks, Chris