From owner-freebsd-bugs@FreeBSD.ORG  Wed Aug 10 18:00:34 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A366116A41F
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 10 Aug 2005 18:00:34 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 70E9643D49
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 10 Aug 2005 18:00:34 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j7AI0YlM048613
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 10 Aug 2005 18:00:34 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j7AI0Yve048612;
	Wed, 10 Aug 2005 18:00:34 GMT (envelope-from gnats)
Date: Wed, 10 Aug 2005 18:00:34 GMT
Message-Id: <200508101800.j7AI0Yve048612@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Maxim Konovalov <maxim@macomnet.ru>
Cc: 
Subject: Re: kern/84761: shutdown() of non-connected socket should fail with
 ENOTCONN
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Maxim Konovalov <maxim@macomnet.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Aug 2005 18:00:34 -0000

The following reply was made to PR kern/84761; it has been noted by GNATS.

From: Maxim Konovalov <maxim@macomnet.ru>
To: James Juran <James.Juran@baesystems.com>
Cc: bug-followup@freebsd.org, rwarson@freebsd.org
Subject: Re: kern/84761: shutdown() of non-connected socket should fail with
 ENOTCONN
Date: Wed, 10 Aug 2005 21:57:44 +0400 (MSD)

 Hi,
 
 [...]
 > Calling shutdown(2) on a non-connected socket should fail with ENOTCONN
 > according to the manpage.  Instead, it succeeds.
 
 Indeed, Linux 2.4 and Solaris 9 return ENOTCONN.  It seems all BSDs
 don't.
 
 > >How-To-Repeat:
 > Run this program.  It should hit the perror(), but instead prints
 > "shutdown succeeded".
 
 Here is a patch but I'm not sure about it and CC'ed rwatson@.  Robert,
 what do you think?
 
 Index: uipc_socket.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/kern/uipc_socket.c,v
 retrieving revision 1.242
 diff -u -p -r1.242 uipc_socket.c
 --- uipc_socket.c	1 Jul 2005 16:28:30 -0000	1.242
 +++ uipc_socket.c	10 Aug 2005 17:20:39 -0000
 @@ -1428,7 +1428,8 @@ soshutdown(so, how)
 
  	if (!(how == SHUT_RD || how == SHUT_WR || how == SHUT_RDWR))
  		return (EINVAL);
 -
 +	if ((so->so_state & SS_ISCONNECTED) == 0)
 +		return (ENOTCONN);
  	if (how != SHUT_WR)
  		sorflush(so);
  	if (how != SHUT_RD)
 %%%
 
 -- 
 Maxim Konovalov