From owner-freebsd-current@freebsd.org Tue Jul 12 15:03:35 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A73F2B93C81 for ; Tue, 12 Jul 2016 15:03:35 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.ChatUSA.com) Received: from pdx.rh.CN85.chatusa.com (br1.CN84in.chatusa.com [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6D9EF137B; Tue, 12 Jul 2016 15:03:34 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.ChatUSA.com) Received: from pdx.rh.CN85.ChatUSA.com (localhost [127.0.0.1]) by pdx.rh.CN85.chatusa.com (8.13.3/8.13.3) with ESMTP id u6CF3Dmt055155; Tue, 12 Jul 2016 08:03:13 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.ChatUSA.com) Received: (from freebsd@localhost) by pdx.rh.CN85.ChatUSA.com (8.13.3/8.13.3/Submit) id u6CF34qX055154; Tue, 12 Jul 2016 08:03:04 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201607121503.u6CF34qX055154@pdx.rh.CN85.ChatUSA.com> Subject: Re: Oversight in /etc/defaults/rc.conf In-Reply-To: <483d186c-ca63-60ef-5703-8a7ae37e9ced@freebsd.org> To: Matthew Seaman Date: Tue, 12 Jul 2016 08:03:04 -0700 (PDT) CC: Glen Barber , freebsd-current@FreeBSD.org, FreeBSD Release Engineering Team X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Mailman-Approved-At: Tue, 12 Jul 2016 15:08:37 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2016 15:03:35 -0000 > On 07/12/16 13:27, Glen Barber wrote: > > On Tue, Jul 12, 2016 at 07:17:19AM +0100, Matthew Seaman wrote: > >> I just upgraded my main machine to 11-STABLE. Things are mostly working > >> fine -- however I did notice that the new iovctl rc script is apparently > >> enabled by default. That seems like a trivial omission: > >> > >> Index: etc/defaults/rc.conf > >> =================================================================== > >> --- etc/defaults/rc.conf (revision 302482) > >> +++ etc/defaults/rc.conf (working copy) > >> @@ -695,6 +695,7 @@ > >> rctl_enable="YES" # Load rctl(8) rules on boot > >> rctl_rules="/etc/rctl.conf" # rctl(8) ruleset. See rctl.conf(5). > >> > >> +iovctl_enable="NO" ^^^^ Missing explination of knob > >> iovctl_files="" # Config files for iovctl(8) > >> > >> ############################################################## > >> > > > > I'm not sure I understand. Is there a functional and/or performance > > impact with it enabled by default? (Note, I don't disable it in my > > rc.conf, and there is no /dev/iov/* on my system.) > > I'm not religious about it being turned off per se. More that it should > have a clearly defined on/off state shown in the defaults. > > I went for 'off' following the general principle that rc.conf items > should mostly be off by default and require specific action to enable. > Yes, there are exceptions to this rule, but I see no particular reason > that iovctl should be one. What's the advantage to turning it on by > default on every FreeBSD installation? > > However, even if it's felt it should be enabled everywhere, then > shouldn't /etc/defaults/rc.conf have: > > iovctl_enable="YES" What ever is resolved you also need to add a # comment describing it. > > instead? > > Cheers, > > Matthew -- Rod Grimes rgrimes@freebsd.org