From owner-freebsd-ports@FreeBSD.ORG Sat Nov 13 01:18:23 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E8A97106564A for ; Sat, 13 Nov 2010 01:18:23 +0000 (UTC) (envelope-from varga.michal@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 5EAC98FC17 for ; Sat, 13 Nov 2010 01:18:22 +0000 (UTC) Received: by bwz2 with SMTP id 2so3612876bwz.13 for ; Fri, 12 Nov 2010 17:18:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=uk6webt6YIt9+8xIZuGsDOAKyhSZ2wlapWhFLQ+0jjs=; b=gCt0MQZuokOuTF6DBPxt8bjFxgL3gYqQjQWncILvlmbmJGBy+Payaf66/AlTdImMc5 H8I/CR+eUqury+azHj3wtY02SP7PpRPosxDx/Ji2dl8lZmA2opLvAet82xEb/FezDhTJ ipEnlf760Fz2ROQGDLmB9fEg7t/fzj4STR8b8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:organization :date:message-id:mime-version:x-mailer:content-transfer-encoding; b=xujX6C98bIAruQOVhsT3uj+CA6YBlReAC8EIcYga3YWZhei3nBJX2MF+c5uKrv/DMD X2e0lHMialU5I+0khPkpY/gDVtYnSj//sLDDeTVvIxVnfvZHm7sGX0FqczI/PeZhr/8D leiLlj4HV5NCBW/dJxLUzl3dHGSZVw9EJZyv0= Received: by 10.204.60.212 with SMTP id q20mr3510655bkh.104.1289609733907; Fri, 12 Nov 2010 16:55:33 -0800 (PST) Received: from [10.0.101.2] (166.153.broadband7.iol.cz [88.102.153.166]) by mx.google.com with ESMTPS id 4sm1798412bki.1.2010.11.12.16.55.31 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 12 Nov 2010 16:55:32 -0800 (PST) From: Michal Varga To: Anonymous In-Reply-To: <86k4kim5rl.fsf@gmail.com> References: <86k4kim5rl.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Organization: Stonehenge Date: Sat, 13 Nov 2010 01:55:30 +0100 Message-ID: <1289609730.1517.16.camel@xenon> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: thomas.e.zander@googlemail.com, Christian Weisgerber , freebsd-ports@freebsd.org Subject: Re: [CFT] mplayer / mencoder port update X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Nov 2010 01:18:24 -0000 On Sat, 2010-11-13 at 03:22 +0300, Anonymous wrote: > Can you try to replace > > #ifdef __FreeBSD__ > > with > > #ifdef __FreeBSD__ && __FreeBSD_version >= 800097 > > Alternatively, just hide the patch under ${OSVERSION} >= 800097. Just my 2 cents: Wouldn't be easier to simply made the patch optional via OPTIONS (defaulting to off) and forget about it? For example, I too have no use for it, as I don't prefer applications messing with my mixer and thus run mplayer with -sotfvol. And seriously, even then, for the past 10 years of pretty heavy mplayer usage - I changed volume in it for like.. three times, ever (probably by accident). So for me, this is a patch that's not part of $Upstream, does absolutely nothing I need, does even less for 4Front OSS users, and is already known to break stuff for someone (the last point being somewhat significant). Please, don't include it by default for everyone. m. -- Michal Varga, Stonehenge (Gmail account)