From owner-cvs-src@FreeBSD.ORG  Thu Sep  4 02:06:45 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3084616A4BF; Thu,  4 Sep 2003 02:06:45 -0700 (PDT)
Received: from anchor-post-31.mail.demon.net (anchor-post-31.mail.demon.net
	[194.217.242.89])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C3B9443FAF; Thu,  4 Sep 2003 02:06:43 -0700 (PDT)
	(envelope-from dfr@nlsystems.com)
Received: from mailgate.nlsystems.com ([80.177.232.242]
	helo=herring.nlsystems.com)
	by anchor-post-31.mail.demon.net with esmtp (Exim 3.35 #1)
	id 19uq4g-000Gjw-0V; Thu, 04 Sep 2003 10:06:42 +0100
Received: from [10.0.0.2] (herring.nlsystems.com [10.0.0.2])
	by herring.nlsystems.com (8.12.9/8.12.8) with ESMTP id h8496WYW092824;
	Thu, 4 Sep 2003 10:06:32 +0100 (BST)
	(envelope-from dfr@nlsystems.com)
From: Doug Rabson <dfr@nlsystems.com>
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
In-Reply-To: <1199.1062664515@critter.freebsd.dk>
References: <1199.1062664515@critter.freebsd.dk>
Content-Type: text/plain
Message-Id: <1062666391.92763.1.camel@herring.nlsystems.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.0 
Date: 04 Sep 2003 10:06:32 +0100
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, hits=-4.9 required=5.0
	tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,
	      REPLY_WITH_QUOTES,USER_AGENT_XIMIAN
	version=2.55
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: "M. Warner Losh" <imp@bsdimp.com>
Subject: Re: cvs commit: src/sys/pci if_sis.c if_sisreg.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Sep 2003 09:06:45 -0000

On Thu, 2003-09-04 at 09:35, Poul-Henning Kamp wrote:
> In message <1062663414.86530.15.camel@herring.nlsystems.com>, Doug Rabson write
> s:
> 
> >For specific drivers, if they really want to change the device
> >description in attach (why not do it in probe like every other driver),
> 
> In the case of the sis driver, the "silicon revision register" is
> stored somewhere in BAR0, so I cannot examine it until the resources
> are allocated.
> 
> I know there are other drivers which could be similarly more detailed
> of the description were set in attach rather than probe.
> 
> I think postpoining the print to after attach might make sense.

I don't think that can happen for the reasons I just mentioned - drivers
which print stuff and drivers which create children.