Date: Tue, 20 Jul 2010 09:57:56 +0200 From: Horvath Andras <han@log69.com> To: Philippe =?UTF-8?B?QXVkw6lvdWQ=?= <jadawin@FreeBSD.org> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/148773: [PATCH] graphics/aaphoto: update to 0.38 Message-ID: <20100720095756.11d1c74b@dell.andras> In-Reply-To: <20100720073407.GA11445@tuxaco.net> References: <201007200653.o6K6rMaM079521@freefall.freebsd.org> <20100720091710.36452d59@dell.andras> <20100720073407.GA11445@tuxaco.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
As i see, you tested it on amd64, which i also tested it on.
I'd like to ask for help to test it on a sparc or ppc system to
compile. It is supposed to compile without the OpenMP option switches.
AFAIK the sparc platform has only GCC v3, and therefore it doesn't have
support for OpenMP. Just like with OS under 7.0 before GCC 4.2.
I agree with you, it may be better that way to test if it's not i386 or
amd64 platform, then it should compile without openmp. The only case it
should compile with openmp if OS is above 7.0 and the arch is whether
amd64 or i386.
I attached another patch. Important part is:
-.if ${ARCH} !=3D "amd64" && ${ARCH} !=3D "i386"
-BROKEN=3D Does not compile on !amd64 and !i386
-.endif
-
-.if ${OSVERSION} >=3D 700000
+.if ${ARCH} =3D=3D "amd64" || ${ARCH} =3D=3D "i386" && ${OSVERSION} >=3D 7=
00000
CFLAGS+=3D -fopenmp -D__OPENMP__
.endif
If somebody could be kind to test it on a sparc, ia64 or pcc system.
Thanks.
On Tue, 20 Jul 2010 09:34:07 +0200
Philippe Aud=C3=A9oud <jadawin@FreeBSD.org> wrote:
> On Tue, 20 Jul 2010, Horvath Andras wrote:
>=20
> > Could anybody help me test the port with the patch to compile on a
> > tier-2 hardware and confirm that it works?
> >=20
> >=20
> > On Tue, 20 Jul 2010 06:53:22 GMT
> > jadawin@FreeBSD.org wrote:
> >=20
> > > Synopsis: [PATCH] graphics/aaphoto: update to 0.38
> > >=20
> > > Responsible-Changed-From-To: freebsd-ports-bugs->jadawin
> > > Responsible-Changed-By: jadawin
> > > Responsible-Changed-When: Tue Jul 20 06:53:22 UTC 2010
> > > Responsible-Changed-Why:=20
> > > I'll take it.
> > >=20
> > > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D148773
> > _______________________________________________
> > freebsd-ports-bugs@freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
> > To unsubscribe, send any mail to
> > "freebsd-ports-bugs-unsubscribe@freebsd.org"
>=20
>=20
> Hello,
>=20
> I tested it on my tinderbox:
>=20
> [...]
> cd .
> && /bin/sh /work/a/ports/graphics/aaphoto/work/aaphoto-0.38/missing
> --run autoheader autoheader: not found
> WARNING: `autoheader' is missing on your system. You should only need
> it if
> you modified `acconfig.h' or `configure.ac'. You might want
> to install the `Autoconf' and `GNU m4' packages. Grab them
> from any GNU archive site.
> [...]
>=20
> from http://a.tchoum.info/tb/logs/7.1-FreeBSD/aaphoto-0.38.log
>=20
> btw i don't really understand why=20
>=20
> -.if ${ARCH} !=3D "amd64" && ${ARCH} !=3D "i386"
> -BROKEN=3D Does not compile on !amd64 and !i386
> -.endif
> -
> -.if ${OSVERSION} >=3D 700000
> +.if ${OSVERSION} >=3D 700000 && \
> + ${ARCH} !=3D "ia64" && \
> + ${ARCH} !=3D "powerpc" && \
> + ${ARCH} !=3D "powerpc64" && \
> + ${ARCH} !=3D "sparc64"
>=20
> is better. if ${ARCH} !=3D "amd64" && ${ARCH} !=3D "i386" is enough to
> test arch.
>=20
> Regards,
>=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100720095756.11d1c74b>