Date: Tue, 14 Jun 2016 09:25:06 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Mark Millard <markmi@dsl-only.net> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: mergemaster internally using make [for example] vs. WITH_META_MODE? Message-ID: <69eb8cb4-2d9b-7019-c9cb-52569090dd8b@FreeBSD.org> In-Reply-To: <533A2977-70C7-44A8-9768-840BAAC3F95F@dsl-only.net> References: <7C577F5B-545C-4D70-A78E-A19E35A24592@dsl-only.net> <36f0c42f-1ca0-f82c-da5b-74cb8f0240e4@FreeBSD.org> <533A2977-70C7-44A8-9768-840BAAC3F95F@dsl-only.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--s2kUrkHmuO7LKcCqct1Vf9BGuNVNQW0AV
Content-Type: multipart/mixed; boundary="jr99nkLgjK9Mh28s0c0cCOLd412FLTv9F"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Mark Millard <markmi@dsl-only.net>
Cc: FreeBSD Current <freebsd-current@freebsd.org>
Message-ID: <69eb8cb4-2d9b-7019-c9cb-52569090dd8b@FreeBSD.org>
Subject: Re: mergemaster internally using make [for example] vs.
WITH_META_MODE?
References: <7C577F5B-545C-4D70-A78E-A19E35A24592@dsl-only.net>
<36f0c42f-1ca0-f82c-da5b-74cb8f0240e4@FreeBSD.org>
<533A2977-70C7-44A8-9768-840BAAC3F95F@dsl-only.net>
In-Reply-To: <533A2977-70C7-44A8-9768-840BAAC3F95F@dsl-only.net>
--jr99nkLgjK9Mh28s0c0cCOLd412FLTv9F
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 6/13/2016 4:31 PM, Mark Millard wrote:
> On 2016-Jun-13, at 3:27 PM, Bryan Drewery <bdrewery@FreeBSD.org> wrote:=
>=20
>> On 6/11/2016 7:28 PM, Mark Millard wrote:
>>> mergemaster [as an example] has code like:
>>>
>>>> # grep -i make /usr/sbin/mergemaster | more
>>> . . .
>>>> MM_MAKE=3D"make ${ARCHSTRING} -m ${SOURCEDIR}/share/mk"
>>>> ${MM_MAKE} DESTDIR=3D${DESTDIR} distrib-dirs >/dev/null
>>>> ${MM_MAKE} DESTDIR=3D${TEMPROOT} distrib-dirs >/dev/null &&
>>>> ${MM_MAKE} _obj SUBDIR_OVERRIDE=3Detc >/dev/null &&
>>>> ${MM_MAKE} everything SUBDIR_OVERRIDE=3Detc >/dev/null &&
>>>> ${MM_MAKE} DESTDIR=3D${TEMPROOT} distribution >/dev/null;} ||
>>> . . .
>>>
>>> If one is using WITH_META_MODE=3D for buildworld, buidlkernel, instal=
lkernel, installworld what is appropriate for scripts or other uses of ma=
ke for other makefile-targets?
>>>
>>> Are there explicit mixes of using WITH_META_MODE=3D for some makefile=
targets and not using WITH_META_MODE=3D for other makefile targets that =
need to be avoided? Does one need to force some scripts to use [or not us=
e] WITH_META_MODE=3D for their "internal" make usage?
>>>
>>
>> Is there an actual bug with mergemaster with WITH_META_MODE?
>>
>>
>> --=20
>> Regards,
>> Bryan Drewery
>=20
> I do not know. I was not sure if lack of WITH_META_MODE=3Dyes for merge=
master's internal make uses might mess up later make commands that use WI=
TH_META_MODE=3Dyes for explicit make activities. Overall that would be a =
mix of with and without.
>=20
> As stands I use the following script for mergemaster (TARGET_ARCH=3Damd=
64 example):
>=20
> # more ~/sys_build_scripts.amd64-host/mergemaster_amd64-amd64-host.sh=20
> script ~/sys_typescripts/typescript_mergemaster_amd64-amd64-host-$(date=
+%Y-%m-%d:%H:%M:%S) \
> env __MAKE_CONF=3D"/root/src.configs/make.conf" SRC_ENV_CONF=3D"/root/s=
rc.configs/src.conf.amd64-clang-bootstrap.amd64-host" \
> MAKEOBJDIRPREFIX=3D"/usr/obj/clang/amd64.amd64" \
> mergemaster -A amd64 $*
>=20
> I've not added WITH_META_MODE=3Dyes to the env yet.
>=20
>=20
> I've been wondering if I should add WITH_META_MODE=3Dyes to such script=
s when the matching "make" script uses WITH_META_MODE=3Dyes --such as:
>=20
> # more ~/sys_build_scripts.amd64-host/make_amd64_nodebug_clang_bootstra=
p-amd64-host.sh=20
> kldload -n filemon && \
> script ~/sys_typescripts/typescript_make_amd64_nodebug_clang_bootstrap-=
amd64-host-$(date +%Y-%m-%d:%H:%M:%S) \
> env __MAKE_CONF=3D"/root/src.configs/make.conf" SRC_ENV_CONF=3D"/root/s=
rc.configs/src.conf.amd64-clang-bootstrap.amd64-host" \
> WITH_META_MODE=3Dyes \
> MAKEOBJDIRPREFIX=3D"/usr/obj/clang/amd64.amd64" \
> make $*
>=20
The targets (at top-level) that META_MODE is applied to is a whitelist
now after r301887. So it's safe to always pass it when building from
the top-level. If it's an unsupported target it will internally disable
META_MODE.
>=20
> [Based on current behavior I normally only use WITH_META_MODE=3Dyes for=
the host targeting its own architecture.]
Cross should be fine now.
>=20
>=20
> =3D=3D=3D
> Mark Millard
> markmi@dsl-only.net
>=20
--=20
Regards,
Bryan Drewery
--jr99nkLgjK9Mh28s0c0cCOLd412FLTv9F--
--s2kUrkHmuO7LKcCqct1Vf9BGuNVNQW0AV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJXYC/iAAoJEDXXcbtuRpfPGA8H/3zqZKiLCVPhR7CQcOWJBHrC
zWdqdboHRXkeY8fapeyTpDitUwJV1/L7HzLjpp2razeVR+qsGs1D7n2uzrRw1QNz
1LQzD4m5omglk64kMgEfW6AnkcSmwSBOAhUd3MsOJ3eeLwLvQTMQmErcOv+5/YUZ
c+ED7AYU2NJ2EpRY1vo5urdGByqzGPKirTQAHQLWM5p7wcmXR+aqeFJmr3iHvQoJ
qwh/eO07H91aV0sUtiO+ZuhEPnBXRKyr4TPr6rQ2zQzxvLxCCAze8cdnqnn+AKo6
l4YA2bssjqpfCi/MZe3eaBSq7Rvu4s91XUPqUZBNxYrfHbylrGmA8ilb3po9+dM=
=y2m7
-----END PGP SIGNATURE-----
--s2kUrkHmuO7LKcCqct1Vf9BGuNVNQW0AV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69eb8cb4-2d9b-7019-c9cb-52569090dd8b>