From owner-svn-src-head@FreeBSD.ORG Tue Nov 5 07:47:22 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A85D8FAF; Tue, 5 Nov 2013 07:47:22 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 26FBD22E2; Tue, 5 Nov 2013 07:47:21 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id rA57lJWC005843 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 5 Nov 2013 11:47:19 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id rA57lJ3U005842; Tue, 5 Nov 2013 11:47:19 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 5 Nov 2013 11:47:19 +0400 From: Gleb Smirnoff To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r257692 - head/sys/netinet Message-ID: <20131105074719.GK1467@FreeBSD.org> References: <201311050744.rA57iFSL062386@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201311050744.rA57iFSL062386@svn.freebsd.org> User-Agent: Mutt/1.5.22 (2013-10-16) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Nov 2013 07:47:22 -0000 On Tue, Nov 05, 2013 at 07:44:15AM +0000, Gleb Smirnoff wrote: T> Rewrite in_control(), so that it is comprehendable without getting mad. T> T> o Provide separate functions for SIOCAIFADDR and for SIOCDIFADDR, with T> clear code flow from beginning to the end. After that the rest of T> in_control() gets very small and clear. T> o Provide sx(9) lock to protect against parallel ioctl() invocations. T> o Reimplement logic from r201282, that tried to keep localhost route in T> table when multiple P2P interfaces with same local address are created T> and deleted. T> T> Discussed with: pluknet, melifaro T> Sponsored by: Netflix T> Sponsored by: Nginx, Inc. This may break things for someone. I am open at throwing stones at me. :) Please report any strangeness you notice and I'll fix it ASAP. -- Totus tuus, Glebius.