From owner-freebsd-current@FreeBSD.ORG Sat Aug 12 10:04:30 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B401316A4DF; Sat, 12 Aug 2006 10:04:30 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 00F3043D45; Sat, 12 Aug 2006 10:04:29 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 2FB9551392; Sat, 12 Aug 2006 12:04:28 +0200 (CEST) Received: from localhost (dkx242.neoplus.adsl.tpnet.pl [83.24.27.242]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 5FC2151339; Sat, 12 Aug 2006 12:04:23 +0200 (CEST) Date: Sat, 12 Aug 2006 12:03:28 +0200 From: Pawel Jakub Dawidek To: Robert Watson Message-ID: <20060812100328.GB73241@garage.freebsd.pl> References: <20060808195202.GA1564@garage.freebsd.pl> <20060810232255.GE1389@garage.freebsd.pl> <20060811143257.E2260@fledge.watson.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aM3YZ0Iwxop3KEKx" Content-Disposition: inline In-Reply-To: <20060811143257.E2260@fledge.watson.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org, Sean Bryant , freebsd-geom@freebsd.org Subject: Re: GJournal (hopefully) final patches. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Aug 2006 10:04:30 -0000 --aM3YZ0Iwxop3KEKx Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 11, 2006 at 02:33:44PM +0100, Robert Watson wrote: >=20 > On Fri, 11 Aug 2006, Pawel Jakub Dawidek wrote: >=20 > >2. Confirm that partition with your file system is _not_ 4 sectors > > aligned. If it is not 4 sectors aligned, it is safe for gjournal to > > use its last sector for metadata. You can verify this by running: > > > > test `diskinfo /dev/ | awk '{print $4}' | xargs -J X ec= ho X % 4 | bc` -eq 0 && echo ok || echo not ok > > > >Then you need to run those commands: > > > > # gjournal label /dev/ /dev/ > > # tunefs -n disable -J enable /dev/.journal >=20 > Sounds like a "gjournal testalignment /dev/partition" would be a very use= ful thing. Or even just doing it as part of gjournal label? Sounds fair. I integrated those checks into 'label' subcommand: When configuring journaling on one provider only, check if UFS file system exists there and if it exists demand -f flag before destroying it. When configuring journaling on two providers, check if UFS exists on the data provider and if the last sector is used by the file system. If it is used, demand -f flag before overwritting it. Next, I want to think a bit how to make those checks more general, so they can be used also in other classes. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --aM3YZ0Iwxop3KEKx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFE3adwForvXbEpPzQRArQjAKCG2gX0ac4N+mdVe13Bo/IJbAILgwCgka8D Ndh04x6cz/C/D7L8kfURqeo= =jYpF -----END PGP SIGNATURE----- --aM3YZ0Iwxop3KEKx--