Date: Sat, 21 Aug 2004 09:50:30 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Giorgos Keramidas <keramida@freebsd.org> Cc: ceri@freebsd.org Subject: Re: To PR Senders Message-ID: <20040821165030.GA20785@odin.ac.hmc.edu> In-Reply-To: <20040820222329.GA29749@gothmog.gr> References: <20040820133029.GE63041@abigail.blackend.org> <20040820103306.5f0ffb6f.wmoran@potentialtech.com> <20040820205835.GH63041@abigail.blackend.org> <20040820222329.GA29749@gothmog.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
--W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 21, 2004 at 01:23:29AM +0300, Giorgos Keramidas wrote: > On 2004-08-20 22:58, Marc Fonvieille <blackend@freebsd.org> wrote: > > On Fri, Aug 20, 2004 at 10:33:06AM -0400, Bill Moran wrote: > > > > > > I don't have the knowledge to make exact recommendations, but perhaps > > > a documented rule of thumb along these lines would help: > > > > > > "Patches in excess of 200k, or which contain over 50 lines of complet= ely > > > new content, should not be attached to the PR, but should be placed on > > > an ftp/web server and the URL included. Patches below these limits > > > should always be attached to the PR." > > > > I don't think giving a limit based on lines number is a good idea. > > 200k is too much, from my point of view, maybe 50k could be the > > maximum... but some may say gzip exists... >=20 > If you really *do* need a recommendation for a size I think that 50k is > about the size that things would probably start getting seriously annoying > for dialup users. Yeah, if a size must be explicitly specified 50k is ok. FYI, bde want's patches at least up to 100K, probably somewhat larger to be inlined. I'd personally, say that whatever he says is definitive (at least on the soruce says). -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --W/nzBZO5zC0uMSeA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBJ31VXY6L6fI4GtQRApyoAKCbbk959t8BqEUkK6DKDtumWHBe2QCgkSkh xSHqKtVaWAID+KCUqpOC4d0= =R0b0 -----END PGP SIGNATURE----- --W/nzBZO5zC0uMSeA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040821165030.GA20785>