From owner-freebsd-stable@FreeBSD.ORG Fri Aug 23 15:33:26 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7812DD10 for ; Fri, 23 Aug 2013 15:33:26 +0000 (UTC) (envelope-from florian@wagner-flo.net) Received: from umbracor.wagner-flo.net (s15308405.onlinehome-server.info [213.165.81.202]) by mx1.freebsd.org (Postfix) with ESMTP id 3B2462F28 for ; Fri, 23 Aug 2013 15:33:25 +0000 (UTC) Received: from naclador.mos32.de (ppp-93-104-191-225.dynamic.mnet-online.de [93.104.191.225]) by umbracor.wagner-flo.net (Postfix) with ESMTPSA id 478343C058F2 for ; Fri, 23 Aug 2013 17:24:10 +0200 (CEST) Date: Fri, 23 Aug 2013 17:24:08 +0200 From: Florian Wagner To: freebsd-stable@freebsd.org Subject: Re: [HEADS UP] change in devfs path matching logic Message-ID: <20130823172408.66ea3280@naclador.mos32.de> In-Reply-To: <52176C7B.4070701@FreeBSD.org> References: <51F28A33.7040209@FreeBSD.org> <52176C7B.4070701@FreeBSD.org> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.20; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/hlWmGbrcwMUpixR6aS2zAm+"; protocol="application/pgp-signature" X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Aug 2013 15:33:26 -0000 --Sig_/hlWmGbrcwMUpixR6aS2zAm+ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 23 Aug 2013 17:06:51 +0300 Andriy Gapon wrote: >=20 > This change is about to be MFC-ed. >=20 > on 26/07/2013 17:39 Andriy Gapon said the following: > >=20 > > I have just committed a significant change to devfs path matching > > logic http://svnweb.freebsd.org/changeset/base/253677 > >=20 > > Jaakko Heinonen (jh@) has full credit for the code while I have full > > responsibility for any consequences of the commit. > >=20 > > Before this change the logic of matching the devfs paths to the > > patterns in devfs rules was quite arcane. Now this logic should be > > much simpler and logical (sorry for tautology). > >=20 > > Please note that nothing changes with respect to matching simple > > paths like /dev/something. It is the complex paths that involve > > subdirectories that are affected. > >=20 > > I think that if you knew how the old logic worked and were able to > > devise rules for it, then you will have no problem to change those > > rules for the new logic. Just please don't forget to do it when you > > upgrade! > >=20 > > I hope that overall you will find this change to be an improvement. > >=20 > > P.S. I notify stable@ because I currently plan to MFC this change > > after 1 month period. If you know a reason why the MFC should not > > be done, please alert me to it. That MFC is rev 254708, isn't it? Is the MFC complete with that single commit? Because that just broke my (coincidentally made) build: cc1: warnings being treated as errors /build/src/sys/fs/devfs/devfs_rule.c: In function 'devfs_rule_matchpath': /build/src/sys/fs/devfs/devfs_rule.c:592: warning: implicit declaration o= f function 'devfs_fqpn' /build/src/sys/fs/devfs/devfs_rule.c:592: warning: nested extern declarat= ion of 'devfs_fqpn' /build/src/sys/fs/devfs/devfs_rule.c:592: warning: assignment makes point= er from integer without a cast Whereas rev 254705 builds successfully... Regards Florian --Sig_/hlWmGbrcwMUpixR6aS2zAm+ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (GNU/Linux) iEYEARECAAYFAlIXfpgACgkQLvW/2gp2pPzl4ACfZQw58Ahhe+R3PIe795QwG+Ca KmkAnj43ysufs/wukEER9JeZOhvvnLGe =+7z0 -----END PGP SIGNATURE----- --Sig_/hlWmGbrcwMUpixR6aS2zAm+--