From owner-freebsd-arch  Fri Jan 18  9:20:17 2002
Delivered-To: freebsd-arch@freebsd.org
Received: from camelot.spsl.nsc.ru (camelot.spsl.nsc.ru [194.226.174.80])
	by hub.freebsd.org (Postfix) with ESMTP id B3D5537B419
	for <arch@freebsd.org>; Fri, 18 Jan 2002 09:20:01 -0800 (PST)
Received: (from root@localhost)
	by camelot.spsl.nsc.ru (8.11.6/8.11.6) id g0IHJs842224
	for arch@freebsd.org.AVP; Fri, 18 Jan 2002 23:19:54 +0600 (NOVT)
	(envelope-from fjoe@iclub.nsu.ru)
Received: from iclub.nsu.ru (root@iclub.nsu.ru [193.124.222.66])
	by camelot.spsl.nsc.ru (8.11.6/8.11.6) with ESMTP id g0IHJrX42215;
	Fri, 18 Jan 2002 23:19:53 +0600 (NOVT)
	(envelope-from fjoe@iclub.nsu.ru)
Received: (from fjoe@localhost)
	by iclub.nsu.ru (8.11.6/8.11.6) id g0IHJuH53624;
	Fri, 18 Jan 2002 23:19:56 +0600 (NS)
	(envelope-from fjoe)
Date: Fri, 18 Jan 2002 23:19:56 +0600
From: Max Khon <fjoe@iclub.nsu.ru>
To: Alexey Dokuchaev <danfe@inet.ssc.nsu.ru>
Cc: arch@freebsd.org
Subject: Re: request for review
Message-ID: <20020118231955.A53559@iclub.nsu.ru>
References: <20020115205053.A9241@iclub.nsu.ru> <Pine.LNX.4.10.10201182050310.13522-100000@inet.ssc.nsu.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <Pine.LNX.4.10.10201182050310.13522-100000@inet.ssc.nsu.ru>; from danfe@inet.ssc.nsu.ru on Fri, Jan 18, 2002 at 09:20:31PM +0600
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-arch.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-arch>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-arch>
X-Loop: FreeBSD.ORG

hi, there!

On Fri, Jan 18, 2002 at 09:20:31PM +0600, Alexey Dokuchaev wrote:

> And the last thing, I've been looking at the patch, and thought, maybe it
> would be more clear to patch vfs_vnops.c the following way instead:
> 
> --- /sys/kern/vfs_vnops.c.orig	Fri Jan 18 21:16:33 2002
> +++ /sys/kern/vfs_vnops.c	Thu Jan 17 20:26:11 2002
> @@ -530,7 +530,7 @@
>          * Default to zero to catch bogus uses of this field.
>          */
> 
> -       if (vap->va_type == VREG) {
> +       if (vap->va_type == VREG || vap->va_type == VCHR) {
>                 sb->st_blksize = vap->va_blocksize;
>         } else if (vn_isdisk(vp, NULL)) {
>                 sb->st_blksize = vp->v_rdev->si_bsize_best;
> 
> What do you think?

this will break `vn_isdisk(vp, NULL)' check (it will always return 0)

/fjoe

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message