From owner-freebsd-current@freebsd.org Fri Oct 12 05:44:42 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F392A10D3E20 for ; Fri, 12 Oct 2018 05:44:41 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 95E7C732BD; Fri, 12 Oct 2018 05:44:41 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (static-71-168-218-4.cmdnnj.fios.verizon.net [71.168.218.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jkim/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 80C851AE98; Fri, 12 Oct 2018 05:44:41 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: r339289 buildworld stopped in /usr/src/secure/lib/libcrypto From: Jung-uk Kim To: Glen Barber , Justin Hibbits Cc: =?UTF-8?B?UmHDumw=?= , freebsd-current@freebsd.org References: <82f64ae7-2e02-59a7-6058-01b33d594517@b2n.org> <20181011190745.GD53700@FreeBSD.org> <20181011153847.76f256df@ralga.knownspace> <20181011164410.6e9a00aa@ralga.knownspace> <20181011223234.GG53700@FreeBSD.org> <20181011225546.GI53700@FreeBSD.org> <20181012005745.GJ53700@FreeBSD.org> <1cc5f351-3037-cc9c-00a8-266bd7967314@FreeBSD.org> Openpgp: preference=signencrypt Autocrypt: addr=jkim@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJBztUBCAChqNyGqmFuNo0U7MBzsD+q/G6Cv0l7LGVrOAsgh34M8wIWhD+tztDWMVfn AhxNDd0ceCj2bYOe67sTQxAScEcbt2FfvPOLp9MEXb9qohZj172Gwkk7dnhOhZZKhVGVZKM4 NcsuBDUzgf4f3Vdzj4wg6WlqplnTZo8lPE4hZWvZHoFIyunPTJWenybeV1xnxK7JkUdSvQR0 fA59RfTTECMwTrSEfYGUnxIDBraxJ7Ecs/0hGQ7sljIj8WBvlRDU5fU1xfF35aw56T8POQRq F4E6RVJW3YGuTpSwgtGZOTfygcLRhAiq3dFC3JNLaTVTpM8PjOinJyt9AU6RoITGOKwDABEB AAHNHkp1bmctdWsgS2ltIDxqa2ltQEZyZWVCU0Qub3JnPsLAfQQTAQoAJwUCUkHO1QIbAwUJ E0/POwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRB8n5Ym/NvxRqyzB/wL7QtsIpeGfGIA ZPMtgXMucM3NWzomyQMln2j2efUkDKthzh9jBxgF53TjOr7imwIt0PT2k1bqctPrq5IRqnu9 mGroqaCLE3LG2/E3jEaao4k9PO6efwlioyivUo5NrqIQOQ4k3EAXw7d2y0Dk1VpTgdMrnUAB hj7lGlLqS4ydcrf24DdbCRGdEQwqd9DBeBgbWynxAJMgbZBhYVEyIHuQKkJ8qY0ibIPXXuF0 KYDeH0qUHtWV2K3srNyPtymUkBQD84Pl1GWRYx05XdUHDmnX0JV3lg0BfYJZgZv0ehPQrMfY Fd9abTkf9FHQYz1JtsC8wUuRgqElRd6+YAGf8Tt9zsBNBFJBztUBCADLtSrP44El2VoJmH14 OFrlOgxzZnbn+Y/Gf1k12mJBiR+A+pBeRLD50p7AiTrjHRxO3cHcl9Dh0uf1VSbXgp8Or0ye iP/86fZPd4k5HXNmDTLL0HecPE08SCqGZ0W8vllQrokB1QxxRUB+fFMPJyMCjDAZ7P9fFTOS dTw1bJSTtOD8Sx8MpZUa9ti06bXFlVYDlaqSdgk181SSx+ZbSKkQR8CIMARlHwiLsa3Z9q9O EJr20HPyxe0AlTvwvFndH61hg7ds63eRvglwRnNON28VXO/lvKXq7Br/CiiyhFdKfINIx2Z5 htYq22tgGTW7mBURbIKoECFBTX9Lv6BXz6w9ABEBAAHCwGUEGAEKAA8FAlJBztUCGwwFCRNP zzsACgkQfJ+WJvzb8UZcJQf+IsTCxUEqY7W/pT84sMg5/QD3s6ufTRncvq14fEOxCNq1Rf4Q 9P+tOFa8GZfKDGB2BFGIrW7uT5mlmKdK1vO6ZIA930y5kUsnCmBUEBJkE2ciSQk01aB/1o62 Q3Gk/F6BwtNY9OXiqF7AcAo+K/BMIaqb26QKeh+IIgK1NN9dQiq3ByTbl4zpGZa6MmsnnRTu mzGKt2nkz7vBzH6+hZp1OzGZikgjjhYWVFoJo1dvf/rv4obs0ZJEqFPQs/1Qa1dbkKBv6odB XJpPH0ssOluTY24d1XxTiKTwmWvHeQkOKRAIfD7VTtF4TesoZYkf7hsh3e3VwXhptSLFnEOi WwYofg== Message-ID: <07925544-3158-0812-56b4-6d4346dd8c1f@FreeBSD.org> Date: Fri, 12 Oct 2018 01:44:22 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1cc5f351-3037-cc9c-00a8-266bd7967314@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="G32THXLYXbnk41VhPG9XiagD6sh5IvCrk" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 05:44:42 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --G32THXLYXbnk41VhPG9XiagD6sh5IvCrk Content-Type: multipart/mixed; boundary="hKO69GqRcyIRY37dGKv62DFssCycezqA6"; protected-headers="v1" From: Jung-uk Kim To: Glen Barber , Justin Hibbits Cc: =?UTF-8?B?UmHDumw=?= , freebsd-current@freebsd.org Message-ID: <07925544-3158-0812-56b4-6d4346dd8c1f@FreeBSD.org> Subject: Re: r339289 buildworld stopped in /usr/src/secure/lib/libcrypto References: <82f64ae7-2e02-59a7-6058-01b33d594517@b2n.org> <20181011190745.GD53700@FreeBSD.org> <20181011153847.76f256df@ralga.knownspace> <20181011164410.6e9a00aa@ralga.knownspace> <20181011223234.GG53700@FreeBSD.org> <20181011225546.GI53700@FreeBSD.org> <20181012005745.GJ53700@FreeBSD.org> <1cc5f351-3037-cc9c-00a8-266bd7967314@FreeBSD.org> In-Reply-To: <1cc5f351-3037-cc9c-00a8-266bd7967314@FreeBSD.org> --hKO69GqRcyIRY37dGKv62DFssCycezqA6 Content-Type: multipart/mixed; boundary="------------879ECB888FA72F86F1E30151" Content-Language: en-US This is a multi-part message in MIME format. --------------879ECB888FA72F86F1E30151 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 18. 10. 12., Jung-uk Kim wrote: > On 18. 10. 11., Glen Barber wrote: >> On Thu, Oct 11, 2018 at 10:55:46PM +0000, Glen Barber wrote: >>> On Thu, Oct 11, 2018 at 10:32:34PM +0000, Glen Barber wrote: >>>> I still see a failure with this applied. >>>> >>>> =3D=3D=3D> lib/libldns (obj,all,install) >>>> /usr/obj/usr/src/powerpc.powerpc/tmp/usr/bin/ld: cannot find -lssl >>>> --- libprivateldns.so.5.full --- >>>> *** [libprivateldns.so.5.full] Error code 1 >>>> >>>> I'll prune .OBJDIR and re-run without -jN to eliminate the possibili= ty >>>> of a build race. >>>> >>> >>> It does not appear to be a build race. >>> >>> =3D=3D=3D> secure/lib/libcrypto (obj,all,install) >>> /usr/src/crypto/openssl/crypto/err/err.c: In function 'err_load_stri= ngs': >>> /usr/src/crypto/openssl/crypto/err/err.c:311: warning: passing argum= ent 2 of 'lh_ERR_STRING_DATA_insert' discards qualifiers from pointer tar= get type >>> /usr/src/crypto/openssl/crypto/err/err.c: In function 'err_load_stri= ngs': >>> /usr/src/crypto/openssl/crypto/err/err.c:311: warning: passing argum= ent 2 of 'lh_ERR_STRING_DATA_insert' discards qualifiers from pointer tar= get type >>> /usr/obj/usr/src/powerpc.powerpc/tmp/usr/bin/ld: cannot find -lpthre= ad >>> *** Error code 1 >>> =20 >>> Stop. >>> make[4]: stopped in /usr/src/secure/lib/libcrypto >>> *** Error code 1 >>> >> >> In fact, on closer inspection, this patch breaks every architecture. >=20 > I forgot to patch one more file, i.e., Makefile.inc1. Please try the > attached patch instead. Darn, I attached an incomplete patch. This should be final. Sorry about the brain farts. I need some sleep. :-( Jung-uk Kim --------------879ECB888FA72F86F1E30151 Content-Type: text/x-patch; name="ldns.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="ldns.diff" Index: Makefile.inc1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- Makefile.inc1 (revision 339324) +++ Makefile.inc1 (working copy) @@ -2534,8 +2534,8 @@ _prebuild_libs=3D ${_kerberos5_lib_libasn1} \ ${_cddl_lib_libctf} \ lib/libufs \ lib/libutil lib/libpjdlog ${_lib_libypclnt} lib/libz lib/msun \ - ${_secure_lib_libcrypto} ${_lib_libldns} \ - ${_secure_lib_libssh} ${_secure_lib_libssl} + ${_secure_lib_libcrypto} ${_secure_lib_libssl} \ + ${_lib_libldns} ${_secure_lib_libssh} =20 .if ${MK_GNUCXX} !=3D "no" _prebuild_libs+=3D gnu/lib/libstdc++ gnu/lib/libsupc++ @@ -2631,9 +2631,10 @@ lib/librtld_db__L: lib/libprocstat__L _secure_lib_libcrypto=3D secure/lib/libcrypto _secure_lib_libssl=3D secure/lib/libssl lib/libradius__L secure/lib/libssl__L: secure/lib/libcrypto__L +secure/lib/libcrypto__L: lib/libthr__L .if ${MK_LDNS} !=3D "no" _lib_libldns=3D lib/libldns -lib/libldns__L: secure/lib/libcrypto__L +lib/libldns__L: secure/lib/libssl__L .endif .if ${MK_OPENSSH} !=3D "no" _secure_lib_libssh=3D secure/lib/libssh Index: lib/libldns/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- lib/libldns/Makefile (revision 339324) +++ lib/libldns/Makefile (working copy) @@ -19,7 +19,7 @@ SRCS=3D buffer.c dane.c dname.c dnssec.c dnssec_sign =20 SRCS+=3D b64_ntop.c b64_pton.c =20 -LIBADD=3D crypto +LIBADD=3D ssl crypto =20 WARNS ?=3D 3 =20 Index: share/mk/src.libnames.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- share/mk/src.libnames.mk (revision 339324) +++ share/mk/src.libnames.mk (working copy) @@ -273,7 +273,7 @@ _DP_mp=3D crypto _DP_memstat=3D kvm _DP_magic=3D z _DP_mt=3D sbuf bsdxml -_DP_ldns=3D crypto +_DP_ldns=3D ssl crypto .if ${MK_OPENSSL} !=3D "no" _DP_fetch=3D ssl crypto .else --------------879ECB888FA72F86F1E30151-- --hKO69GqRcyIRY37dGKv62DFssCycezqA6-- --G32THXLYXbnk41VhPG9XiagD6sh5IvCrk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlvANLgACgkQfJ+WJvzb 8Uaq2gf7BP/RtrAMeHYUGpGINrGfvcSoabpyhTxUvbZz4v4Tc6Z7XjDjTJk5Zh1h z7fLRZmOa3NeI5v698ENN6m5dxUx7GW2GMJlgQij3bzCqpYTwmf7sU5Lsqq1pXg9 SXDeXrMzVZ8IeWOGBxcvRAaMnj1v1h+i20RhVbUZFg9hGQ1lnrYh97ZOILn7rId2 6WzUNXItsqyI6Mgd+npcK9s0QG/4LpSDPG5gU0NFQKUU80KQYwE2WGDshIuzz3kx 1TR5B9ynlJj6088NFduwbmTOPyMrB/+5B8gie6HcO16TY14T+vIpexiecmeiEjZP 3P8kphP1L+GAKbbBxrCE91iO4d2BhQ== =WTqA -----END PGP SIGNATURE----- --G32THXLYXbnk41VhPG9XiagD6sh5IvCrk--