From owner-svn-src-head@freebsd.org Sun Mar 3 20:28:58 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D19D8151885C for ; Sun, 3 Mar 2019 20:28:57 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 17CE56AAC6 for ; Sun, 3 Mar 2019 20:28:56 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1551644925; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=Bbb9slN/obZFX03nvnWgXUWiMcECcsKL91NXiLzXvUE4+JpjRGIp9/RXasSjHtZ38sXizj4wDJKMQ hbcCdMHlapH5nQShZyXq6Lt7KOgCQYxRuJdT8iXBjGAJYmsaw+INOOusnPcZYijDFqU8imU69589Wm cxMz5u9JGEWBxbLHOMIALE3ybR8hxHmlg2uLvW0bBZcKk3obPkU3/Mif/U2o4C/OTe8hTq/iZ8WUD8 Mh0N0MhocBaNVpI0Y2OerD9hIZCuY644ZMx2NkYmgyvVJ8ciBkbo2ocWIFhcIgd5ndO37A4eXz4Nks ogjX/mkjgOpDYFF8kHE26MbubbBbzhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=LTrd0UHBRe0R54jRXV2nNnmuEfMClrJnrJHvo4y6JyA=; b=JoUeo69J1NcegtCUkOu/EeeDfDW3axykoufm6mrxB+kSNpmhlr9DV8fa5a2zcYRBD3HIFm/OmtqVq Fet3uRiIwjg9TjZ2kwBpcYXMp919sGHvtuHqFywlNnnvvRu3dHV5iAn63aeTZAx9IYYK17HMPnJVjt 2WEzH3HVU2GxHRHWJOH9kIjmkn0+2xto3C2O7JoTNUtoE1T6GtkZsNwOwEQw7xGpM19NEzlgk2uYg4 nVnsEqODw5vYGfDt8Ejm3UXr4jFAqm2QfPXswjd82TLdeiX+SleaPZwsOkA4tanKLm09vG6j/i5FB5 MN3mKSqsOJvF3x34bdTsRlSdJLFvyYg== ARC-Authentication-Results: i=1; outbound2.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=LTrd0UHBRe0R54jRXV2nNnmuEfMClrJnrJHvo4y6JyA=; b=fvQzb1DwaHwpIesVf22yZ8BumwVj3tdOa9xhyCrTxv+jIkViP9E6N86OcA2JaL8fi4A4hYanennmD F1u1ompuK25w1QM/IBX/9o7UXvURf9vMn6GPLAD1PRnz60tK+t/nxlgXKjKhEBR8tdwH+y57EpPGpY sqxn4ZCUai0mFT/t8dyAKWyaiPHHAN18C0OPyB+yUSFqA4crHtPF4MtxxvbOfCUob5sA9zNzfifQlP ZV1inCmxJzOWfubjYK/xuqHQyLiddCj76Rs3lpl8fJe+PLJLT96lxW0ZPRISGCrgXlU5DgWsaO7BX+ NEGFdv7gD2/teA/efK/ykqA7mmYvMeQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: ef4d79e9-3df2-11e9-803b-31925da7267c X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.eu.mailhop.org (Halon) with ESMTPSA id ef4d79e9-3df2-11e9-803b-31925da7267c; Sun, 03 Mar 2019 20:28:43 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x23KSfwi017449; Sun, 3 Mar 2019 13:28:41 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel@freebsd.org> Subject: Re: svn commit: r344701 - head/sbin/camcontrol From: Ian Lepore To: Enji Cooper , Steven Hartland Cc: Alexey Dokuchaev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sun, 03 Mar 2019 13:28:41 -0700 In-Reply-To: <64CCD099-1916-4ACC-B1B6-3F22BDE55C7C@gmail.com> References: <201903011439.x21EdFlH055596@repo.freebsd.org> <20190302104909.GA25217@FreeBSD.org> <64CCD099-1916-4ACC-B1B6-3F22BDE55C7C@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 17CE56AAC6 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; ASN(0.00)[asn:16509, ipnet:52.58.0.0/15, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Mar 2019 20:28:58 -0000 On Sun, 2019-03-03 at 12:20 -0800, Enji Cooper wrote: > > On Mar 3, 2019, at 11:12, Steven Hartland > > wrote: > > > > Not really much more to say that isn't explained by that and the > > code. > > > > Sure I could have used a different sentence structure for the body > > but it wouldn't add anything IMO, thoughts? > > Why the previous sector size was wrong isn’t clear from the > commit message. Why switch from a sizeof to 0? > Cheers! > -Enji > The commit message said it was "incorrect / unused". While a bit terse, it does communicate that the old value was incorrect (by being there at all) because the value is unused (so zero more clearly expresses that). It's not completely a joke that most English-speaking software engineers have English as a second language. :) -- Ian