From nobody Tue Mar 10 16:53:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fVg2B50pDz6Vwmg for ; Tue, 10 Mar 2026 16:53:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fVg2B3ffMz3lCx for ; Tue, 10 Mar 2026 16:53:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773161634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JeVFDjTiofdrYk8VBh76wspnnkxz704Hf1z7AiU/kkg=; b=iKK/BYHZN5Twtav6fKOzbEhvBEh5EdrBDsQJEmTiq5ZAQA1Cs16ghnGq1VC32jzvgcSIaL 4b9BhAqQGgdFJsWXS5QJ7kEXE7FbzMFt/ZmBsturJdeT83r2CtGFBzVD3/rW0H15CB8HcL XY+X+PMuIepD8g3YhRFoMjHVKN32NIyIaImUxJG8juFzSb90X68R88tg9GVkp62L9Xav+q AY27EkZkCUzOFyGZLHPaAVD/bFABQf775ExhVJPTNJieiTrimEW8aIvQB2q6GPIFUmXldL hekpE2zOXM9sm8pclLAXPxPk4X2rD6BZvQEWfVl0KNtjtWvSMyvt500ZiYA0bQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773161634; a=rsa-sha256; cv=none; b=sPDPpGGvpkoPytU/XclQLZBavewL8VG6yVUIWBkOV7OzHa9ov5tGLI73iZALJqsk3oGsKd hv/5m7aa3Gxu1jW3NA0xRbNrcYS0j2dBhQODiPxjqQkoJ2qAWJxqwbb5xF/YztKT7YPXXF 4Vctt0Y/Sr1l7TD50GlJQQr+e5JWAwcPBu1Jzk9QDAPvsqs+tIPX2gRmVhXsSNbp9I4afh Ga/H2AQNxsVraU8IrQUmtW5P2N8nR0FLF86xzR2Sobt6T2hM+T4Uii3frvvtRGCkDnFkBr bt81O6xM1kfAdfOnpKQO2tQS0e0cGIPjwrUkGT3o1bMniyCUJJxecW01mSW3Ug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773161634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JeVFDjTiofdrYk8VBh76wspnnkxz704Hf1z7AiU/kkg=; b=XRoC/W/kq/QP5JTwtpLQAMH4INvICLMIjSm6ISSGxH0tfFRxjyk+YINvgQa7VHwvfdhv2e tixhQhRyNhPx4kYZ2CZhS858A6GJMYZXWXXOS40id1mG5OMWwRf1BaOEWRVE3gdiTYr3Xj f9TWMsi6EFX7YeYldOSgexokXfD7Y4P8yrTIhn1RzaukIeOI7VdHyqTVziyD7CVPpwZl3E GBHrtqq5FKlNP1P9XjUKK30j7gKSxlM4KNsj3OejKZoBqisdM/filEDv2N0nsBThMQA+ui a/hxaP6xqwF6I0OI+GDVp5+KS/te12yYIZndwFxv5xDyDGxtxzer5mC2UEdlrw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fVg2B1Rf3z574 for ; Tue, 10 Mar 2026 16:53:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4540f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Mar 2026 16:53:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: c8fb16542a52 - main - pciconf: Use a single enum to track the current operation mode List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c8fb16542a52ca889c1adf56b2ce13b4ad4cf887 Auto-Submitted: auto-generated Date: Tue, 10 Mar 2026 16:53:54 +0000 Message-Id: <69b04ca2.4540f.6a857cbc@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=c8fb16542a52ca889c1adf56b2ce13b4ad4cf887 commit c8fb16542a52ca889c1adf56b2ce13b4ad4cf887 Author: John Baldwin AuthorDate: 2026-03-10 16:48:16 +0000 Commit: John Baldwin CommitDate: 2026-03-10 16:48:16 +0000 pciconf: Use a single enum to track the current operation mode Reviewed by: imp Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D55769 --- usr.sbin/pciconf/pciconf.c | 66 ++++++++++++++++++++++++++-------------------- 1 file changed, 38 insertions(+), 28 deletions(-) diff --git a/usr.sbin/pciconf/pciconf.c b/usr.sbin/pciconf/pciconf.c index 6aa33d332c08..6c26621ae186 100644 --- a/usr.sbin/pciconf/pciconf.c +++ b/usr.sbin/pciconf/pciconf.c @@ -71,7 +71,7 @@ static struct pcisel getsel(const char *str); static void list_bridge(int fd, struct pci_conf *p); static void list_bars(int fd, struct pci_conf *p); static void list_devs(const char *name, int verbose, int bars, int bridge, - int caps, int errors, int vpd, int listmode); + int caps, int errors, int vpd, int compact); static void list_verbose(struct pci_conf *p); static void list_vpd(int fd, struct pci_conf *p); static const char *guess_class(struct pci_conf *p); @@ -103,17 +103,17 @@ int main(int argc, char **argv) { int c, width; - int listmode, readmode, writemode, attachedmode, dumpbarmode; - int bars, bridge, caps, errors, verbose, vpd; + enum { NONE, LIST, READ, WRITE, ATTACHED, DUMPBAR } mode; + int compact, bars, bridge, caps, errors, verbose, vpd; - listmode = readmode = writemode = attachedmode = dumpbarmode = 0; - bars = bridge = caps = errors = verbose = vpd= 0; + mode = NONE; + compact = bars = bridge = caps = errors = verbose = vpd = 0; width = 4; while ((c = getopt(argc, argv, "aBbcDehlrwVvx")) != -1) { switch(c) { case 'a': - attachedmode = 1; + mode = ATTACHED; break; case 'B': @@ -130,7 +130,7 @@ main(int argc, char **argv) break; case 'D': - dumpbarmode = 1; + mode = DUMPBAR; break; case 'e': @@ -142,15 +142,17 @@ main(int argc, char **argv) break; case 'l': - listmode++; + if (mode == LIST) + compact = 1; + mode = LIST; break; case 'r': - readmode = 1; + mode = READ; break; case 'w': - writemode = 1; + mode = WRITE; break; case 'v': @@ -170,30 +172,38 @@ main(int argc, char **argv) } } - if ((listmode && optind >= argc + 1) - || (writemode && optind + 3 != argc) - || (readmode && optind + 2 != argc) - || (attachedmode && optind + 1 != argc) - || (dumpbarmode && (optind + 2 > argc || optind + 4 < argc)) - || (width == 8 && !dumpbarmode)) - usage(); - - if (listmode) { + switch (mode) { + case LIST: + if (optind >= argc + 1) + usage(); list_devs(optind + 1 == argc ? argv[optind] : NULL, verbose, - bars, bridge, caps, errors, vpd, listmode); - } else if (attachedmode) { + bars, bridge, caps, errors, vpd, compact); + break; + case ATTACHED: + if (optind + 1 != argc) + usage(); chkattached(argv[optind]); - } else if (readmode) { + break; + case READ: + if (optind + 2 != argc || width == 8) + usage(); readit(argv[optind], argv[optind + 1], width); - } else if (writemode) { + break; + case WRITE: + if (optind + 3 != argc || width == 8) + usage(); writeit(argv[optind], argv[optind + 1], argv[optind + 2], width); - } else if (dumpbarmode) { + break; + case DUMPBAR: + if (optind + 2 > argc || optind + 4 < argc) + usage(); dump_bar(argv[optind], argv[optind + 1], optind + 2 < argc ? argv[optind + 2] : NULL, optind + 3 < argc ? argv[optind + 3] : NULL, width, verbose); - } else { + break; + default: usage(); } @@ -258,7 +268,7 @@ fetch_devs(int fd, const char *name, struct pci_conf **confp, size_t *countp) static void list_devs(const char *name, int verbose, int bars, int bridge, int caps, - int errors, int vpd, int listmode) + int errors, int vpd, int compact) { int fd; struct pci_conf *conf, *p; @@ -279,11 +289,11 @@ list_devs(const char *name, int verbose, int bars, int bridge, int caps, return; } - if (listmode == 2) + if (compact) printf("drv\tselector\tclass rev hdr " "vendor device subven subdev\n"); for (p = conf; p < conf + count; p++) { - if (listmode == 2) + if (compact) printf("%s%d@pci%d:%d:%d:%d:" "\t%06x %02x %02x " "%04x %04x %04x %04x\n",