From owner-freebsd-hackers  Thu Apr 10 06:31:41 1997
Return-Path: <owner-hackers>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id GAA05099
          for hackers-outgoing; Thu, 10 Apr 1997 06:31:41 -0700 (PDT)
Received: from kremvax.demos.su (kremvax.demos.su [194.87.0.20])
          by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id GAA05089
          for <hackers@freebsd.org>; Thu, 10 Apr 1997 06:31:35 -0700 (PDT)
Received: by kremvax.demos.su (8.6.13/D) from 0@skraldespand.demos.su [194.87.0.19]
          with ESMTP id RAA04419; Thu, 10 Apr 1997 17:26:25 +0400
Received: by skraldespand.demos.su id RAA14530;
  (8.8.5/D) Thu, 10 Apr 1997 17:27:30 +0400 (MSD)
Message-Id: <199704101327.RAA14530@skraldespand.demos.su>
Subject: Re: ipfilter-proff backported to 2.2.1
In-Reply-To: <19970410110853.6196.qmail@suburbia.net> from "proff@suburbia.net" at "Apr 10, 97 09:08:52 pm"
X-ELM-OSV: (Our standard violations) no-mime=1; no-hdr-encoding=1
To: proff@suburbia.net
Date: Thu, 10 Apr 1997 17:27:29 +0400 (MSD)
Cc: hackers@freebsd.org
From: "Mikhail A. Sokolov" <mishania@demos.su>
X-Class: Fast
Organization: Demos Company, Ltd.
Reply-To: mishania@demos.su
X-Mailer: ELM [version 2.4ME+ PL31 (25)]
Content-Type: text
Sender: owner-hackers@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

> Replace src/sys-ipfilter-proff.diff after unpacking the

Succeeded with 2.2.1-R "stock", I just reistalled full sources and made it with
your patch. Though, I have few comments:
In this files, are you sure we want if_var.h included with 2.2.1? Since there's
no <net/if_var.h> in 2.2.1, it should read like 

#include <net/if.h>
#if __FreeBSD_version > 220000
# include <net/if_var.h>
# endif

I.e. it might be good to make it ">", not ">=".

/src/contrib-sys/ipfilter/ip_fil.c	optional ipfilter inet
/src/contrib-sys/ipfilter/fil.c		optional ipfilter inet
/src/contrib-sys/ipfilter/ip_nat.c	optional ipfilter inet
/src/contrib-sys/ipfilter/ip_frag.c	optional ipfilter inet
/src/contrib-sys/ipfilter/ip_state.c	optional ipfilter inet

 As for this line, which finally goes to /sys/compile/MACHINE/, are you sure 
about -nostdinc? See, it fails in make depend, since it can't find simple
things like <stddef.h> etc. I saw it _having_ /usr/src/include and /usr/include,
and /usr/include/sys/ is correctly linked.

+INCLUDES= -nostdinc -I- -I. -I$S -I${.IMPSRC:H}
 # This hack is to allow kernel compiles to succeed on machines w/out srcdist


Now it was only 2 warning about redundant redeclaration of `ipfr_slowtimer` in
ip_frag.h, lines 85 and 47 respectively.

Thanks you, 

-mishania