From owner-freebsd-current@FreeBSD.ORG  Mon Jun  7 20:24:49 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 092FB16A4CE
	for <freebsd-current@freebsd.org>;
	Mon,  7 Jun 2004 20:24:49 +0000 (GMT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7E56543D31
	for <freebsd-current@freebsd.org>;
	Mon,  7 Jun 2004 20:24:48 +0000 (GMT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i57KNpip020599;
	Mon, 7 Jun 2004 16:23:51 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)i57KNpQq020596;
	Mon, 7 Jun 2004 16:23:51 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Mon, 7 Jun 2004 16:23:51 -0400 (EDT)
From: Robert Watson <rwatson@freebsd.org>
X-Sender: robert@fledge.watson.org
To: Arjan van Leeuwen <avleeuwen@piwebs.com>
In-Reply-To: <200406072216.29044.avleeuwen@piwebs.com>
Message-ID: <Pine.NEB.3.96L.1040607162320.88690F-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-current@freebsd.org
cc: "David A. Benfell" <benfell@parts-unknown.org>
Subject: Re: file descripter leak in current with Qmail?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jun 2004 20:24:49 -0000


On Mon, 7 Jun 2004, Arjan van Leeuwen wrote:

> > It could be that this is related to the esd file descriptor leak problem
> > also being reported.  You might also try the attached patch.
> 
> I get a panic (address not allocated) when using the patch. I can't
> write down any useful details about it right now, because although the
> server has only 3 users, they're very disconcerned when I disrupt their
> internet traffic :). 

Just ran into that myself once the build finished -- looks like 'sa' isn't
being initialized to NULL.  I'll send a follow-up patch shortly.

> 
> Best regards,
> 
> Arjan
> 
> >
> > Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
> > robert@fledge.watson.org      Senior Research Scientist, McAfee Research
> >
> > Index: uipc_syscalls.c
> > ===================================================================
> > RCS file: /data/ncvs/src/sys/kern/uipc_syscalls.c,v
> > retrieving revision 1.187
> > diff -u -r1.187 uipc_syscalls.c
> > --- uipc_syscalls.c	7 Jun 2004 09:59:50 -0000	1.187
> > +++ uipc_syscalls.c	7 Jun 2004 19:38:39 -0000
> > @@ -285,7 +285,7 @@
> >  	if ((head->so_state & SS_NBIO) && TAILQ_EMPTY(&head->so_comp)) {
> >  		ACCEPT_UNLOCK();
> >  		error = EWOULDBLOCK;
> > -		goto done;
> > +		goto noconnection;
> >  	}
> >  	while (TAILQ_EMPTY(&head->so_comp) && head->so_error == 0) {
> >  		if (head->so_state & SS_CANTRCVMORE) {
> > @@ -296,14 +296,14 @@
> >  		    "accept", 0);
> >  		if (error) {
> >  			ACCEPT_UNLOCK();
> > -			goto done;
> > +			goto noconnection;
> >  		}
> >  	}
> >  	if (head->so_error) {
> >  		error = head->so_error;
> >  		head->so_error = 0;
> >  		ACCEPT_UNLOCK();
> > -		goto done;
> > +		goto noconnection;
> >  	}
> >  	so = TAILQ_FIRST(&head->so_comp);
> >  	KASSERT(!(so->so_qstate & SQ_INCOMP), ("accept1: so SQ_INCOMP"));
> >
> >
> >
> > !DSPAM:40c4c5b6283404763116770!
>