From nobody Mon Jan 12 17:33:13 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dqfbt3QwBz6NsBg for ; Mon, 12 Jan 2026 17:33:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dqfbt0NRCz473C for ; Mon, 12 Jan 2026 17:33:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768239194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RXY0zRkB75SDqtyqYlxqAVUurTQP1Z/gMQkdOpQFyJg=; b=krhsri4ZIVC7VT9dXI8tObJQjJ/XUMizuXU2AYXphCdZr2VqUFdt7gHtc+W+sqKlJEbZ5l OxHTp4JDXh9RiYN/dWlcO5C4TOb5F526c0y3OErzHcJxMkrMsoOCdYUqopN81I6bW5yKd1 XYHX6ERtiHxhiZCh4ZpPII3tE3gg6cG+K6BZkGscRfTTGCLlzsDOAX/4hrI2jtVSC2m3cD vhNcOvzydJpPA2dtSoS1aEk7N3hnArBEZyVmK+dRJq1yGRJBtkcbhHf6vTcBftMJ4CWhLT vvD9eTBbqczyhwtLe82Rrkc1bi9H3JhpZVh+1ouhyp3aUasYdo49nOeSw+EZ9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768239194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RXY0zRkB75SDqtyqYlxqAVUurTQP1Z/gMQkdOpQFyJg=; b=FnsIjSqGYF6937yJ+QB07wMyGWcZprMzZL1bLWtkqdQO1pr65qcDYtfUapFxpo5q33uJc0 6t/QbN708DMCJxXcEl+2ju9OKDsHLjY02bG7EAxU2zj+kPJxo9HBML79CuQ1WJahYZNK10 RQiZnkh1ZwSYK0kR3TLO5/VqXQIbm6+IIVjmTrrpEhTDqiVJzK/tPYNSVQzkuZiCztIKEm tDhlPz1Cg0P2Z1N525zk3fkRnzRGv0MdYlR13RCpeDwmWnXRVDIU8sMqRa6Td4uhJdKsnh kK8wraW/BJc4Z53/GDtDLrdsBm+4+sFf+1wQ9hOpIv+ZtCMe5/5YfW0jWVt1tA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768239194; a=rsa-sha256; cv=none; b=Mzz1zygT0rGzY4yEs+AC2LsTT04UbN7sfMKWzPhiMoSc5Q+5MzLoyROsX+1yFhZmxCw03B n6KJMYBZW3o6MWU6cDEnw8DQ7/kqFvDPFdHKPKRwMFkfTwo5LswAt0ZGH3EFSDgbNAmBpu sekGiiuha7C9EFQyrNUTX6O6caX+GNekF587tqS5zg0f7CMX+OiO/0gV1AKoeQtaGo6nFk lzHlldrt3NuPbTPLpSWLCGRqRWUthtu6stJWYxLxHMYlF7E5oKYhZjkLFmv2ccPoW9NBGM LftSB6HFDw1eZuVVJ3dMA7AMHaQTXTCeGMKQ98oL7nKIxsqAOViJvJa+WligxQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dqfbs6xwCzc1Y for ; Mon, 12 Jan 2026 17:33:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 378e6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Jan 2026 17:33:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: c72aa343a620 - stable/15 - ng_tty: avoid the sign extention of char List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: c72aa343a620b15cbf5f6364814e881c634df837 Auto-Submitted: auto-generated Date: Mon, 12 Jan 2026 17:33:13 +0000 Message-Id: <69653059.378e6.5bc13c47@gitrepo.freebsd.org> The branch stable/15 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=c72aa343a620b15cbf5f6364814e881c634df837 commit c72aa343a620b15cbf5f6364814e881c634df837 Author: Ahmad Khalifa AuthorDate: 2026-01-06 02:07:29 +0000 Commit: Ahmad Khalifa CommitDate: 2026-01-12 17:24:54 +0000 ng_tty: avoid the sign extention of char When c is compared to sc->hotchar, both undergo integer promotion, which can lead to c being sign extended. Fix this by casting c to an unsigned char. Reviewed by: kevans MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54544 (cherry picked from commit 9b2478f60bfda663c84b48e272a2293159e1b0a0) --- sys/netgraph/ng_tty.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index 0e3230a66f66..200a72336110 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -489,7 +489,8 @@ ngt_rint(struct tty *tp, char c, int flags) m->m_pkthdr.len++; /* Ship off mbuf if it's time */ - if (sc->hotchar == -1 || c == sc->hotchar || m->m_len >= MHLEN) { + if (sc->hotchar == -1 || (u_char)c == sc->hotchar || + m->m_len >= MHLEN) { sc->m = NULL; NG_SEND_DATA_ONLY(error, sc->hook, m); /* Will queue */ }