Date: Thu, 6 May 1999 22:55:11 +0200 (CEST) From: Nick Hibma <hibma@skylink.it> To: Kenneth Merry <ken@FreeBSD.org> Cc: CVS Committers FreeBSD <cvs-committers@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/camcontrol camcontrol.8 camcontrol.c src/sys/cam cam_ccb.h cam_sim.c cam_sim.h cam_xpt.c src/sys/cam/scsi scsi_cd.c scsi_da.c scsi_pass.c scsi_pass.h src/sys/dev/advansys advansys.c advlib.c adwcam.c src/sys/dev/aha ... Message-ID: <Pine.BSF.3.96.990506222513.731D-100000@heidi.plazza.it> In-Reply-To: <199905062016.NAA03247@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
The change in vpo.c was
@@ -421,6 +421,7 @@
cpi->max_lun = 0;
cpi->initiator_id = VP0_INITIATOR;
cpi->bus_id = sim->bus_id;
+ cpi->base_transfer_speed = 3300;
strncpy(cpi->sim_vid, "FreeBSD", SIM_IDLEN);
strncpy(cpi->hba_vid, "Iomega", HBA_IDLEN);
strncpy(cpi->dev_name, sim->sim_name, DEV_IDLEN);
What about the call to
cam_sim_set_basexfer_speed(vpo->sim, 93/*kB/s*/);
should it be removed?
Second, the 3300 is quite different from the 93 kb/s. This looks a
cut&paste bogon. 93kb/s is more like perceived performance on ppbus.
Just asking because the dev/usb/umass driver needs updating as well
(iomega USB Zip drive driver).
Nick
On Thu, 6 May 1999, Kenneth Merry wrote:
> ken 1999/05/06 13:16:41 PDT
>
> Modified files:
> sbin/camcontrol camcontrol.8 camcontrol.c
> sys/cam cam_ccb.h cam_sim.c cam_sim.h cam_xpt.c
> sys/cam/scsi scsi_cd.c scsi_da.c scsi_pass.c
> scsi_pass.h
> sys/dev/advansys advansys.c advlib.c adwcam.c
> sys/dev/aha aha.c
> sys/dev/aic7xxx aic7xxx.c
> sys/dev/buslogic bt.c
> sys/dev/dpt dpt_scsi.c
> sys/dev/isp isp_freebsd.c
> sys/dev/ppbus vpo.c
> sys/i386/eisa ahb.c
> sys/i386/isa/bs bs.c
> sys/pci ncr.c simos.c
> Log:
> Add a number of interrelated CAM feature enhancements and bug fixes.
>
> NOTE: These changes will require recompilation of any userland
> applications, like cdrecord, xmcd, etc., that use the CAM passthrough
> interface. A make world is recommended.
>
> camcontrol.[c8]:
> - We now support two new commands, "tags" and "negotiate".
>
> - The tags commands allows users to view the number of tagged
> openings for a device as well as a number of other related
> parameters, and it allows users to set tagged openings for
> a device.
>
> - The negotiate command allows users to enable and disable
> disconnection and tagged queueing, set sync rates, offsets
> and bus width. Note that not all of those features are
> available for all controllers. Only the adv, ahc, and ncr
> drivers fully support all of the features at this point.
> Some cards do not allow the setting of sync rates, offsets and
> the like, and some of the drivers don't have any facilities to
> do so. Some drivers, like the adw driver, only support enabling
> or disabling sync negotiation, but do not support setting sync
> rates.
>
> - new description in the camcontrol man page of how to format a disk
> - cleanup of the camcontrol inquiry command
> - add support in the 'devlist' command for skipping unconfigured devices if
> -v was not specified on the command line.
> - make use of the new base_transfer_speed in the path inquiry CCB.
> - fix CCB bzero cases
>
> cam_xpt.c, cam_sim.[ch], cam_ccb.h:
>
> - new flags on many CCB function codes to designate whether they're
> non-immediate, use a user-supplied CCB, and can only be passed from
> userland programs via the xpt device. Use these flags in the transport
> layer and pass driver to categorize CCBs.
>
> - new flag in the transport layer device matching code for device nodes
> that indicates whether a device is unconfigured
>
> - bump the CAM version from 0x10 to 0x11
>
> - Change the CAM ioctls to use the version as their group code, so we can
> force users to recompile code even when the CCB size doesn't change.
>
> - add + fill in a new value in the path inquiry CCB, base_transfer_speed.
> Remove a corresponding field from the cam_sim structure, and add code to
> every SIM to set this field to the proper value.
>
> - Fix the set transfer settings code in the transport layer.
>
> scsi_cd.c:
>
> - make some variables volatile instead of just casting them in various
> places
> - fix a race condition in the changer code
> - attach unless we get a "logical unit not supported" error. This should
> fix all of the cases where people have devices that return weird errors
> when they don't have media in the drive.
>
> scsi_da.c:
>
> - attach unless we get a "logical unit not supported" error
>
> scsi_pass.c:
>
> - for immediate CCBs, just malloc a CCB to send the user request in. This
> gets rid of the 'held' count problem in camcontrol tags.
>
> scsi_pass.h:
>
> - change the CAM ioctls to use the CAM version as their group code.
>
> adv driver:
>
> - Allow changing the sync rate and offset separately.
>
> adw driver
>
> - Allow changing the sync rate and offset separately.
>
> aha driver:
>
> - Don't return CAM_REQ_CMP for SET_TRAN_SETTINGS CCBs.
>
> ahc driver:
>
> - Allow setting offset and sync rate separately
>
> bt driver:
>
> - Don't return CAM_REQ_CMP for SET_TRAN_SETTINGS CCBs.
>
> NCR driver:
>
> - Fix the ultra/ultra 2 negotiation bug
> - allow setting both the sync rate and offset separately
>
> Other HBA drivers:
> - Put code in to set the base_transfer_speed field for
> XPT_GET_TRAN_SETTINGS CCBs.
>
> Reviewed by: gibbs, mjacob (isp), imp (aha)
>
> Revision Changes Path
> 1.11 +196 -4 src/sbin/camcontrol/camcontrol.8
> 1.10 +865 -46 src/sbin/camcontrol/camcontrol.c
> 1.5 +81 -39 src/sys/cam/cam_ccb.h
> 1.2 +3 -10 src/sys/cam/cam_sim.c
> 1.2 +5 -8 src/sys/cam/cam_sim.h
> 1.55 +45 -23 src/sys/cam/cam_xpt.c
> 1.18 +15 -20 src/sys/cam/scsi/scsi_cd.c
> 1.22 +6 -7 src/sys/cam/scsi/scsi_da.c
> 1.7 +45 -3 src/sys/cam/scsi/scsi_pass.c
> 1.2 +4 -4 src/sys/cam/scsi/scsi_pass.h
> 1.10 +38 -7 src/sys/dev/advansys/advansys.c
> 1.13 +3 -2 src/sys/dev/advansys/advlib.c
> 1.3 +16 -10 src/sys/dev/advansys/adwcam.c
> 1.22 +3 -2 src/sys/dev/aha/aha.c
> 1.25 +12 -2 src/sys/dev/aic7xxx/aic7xxx.c
> 1.20 +3 -2 src/sys/dev/buslogic/bt.c
> 1.23 +2 -1 src/sys/dev/dpt/dpt_scsi.c
> 1.17 +9 -10 src/sys/dev/isp/isp_freebsd.c
> 1.12 +2 -1 src/sys/dev/ppbus/vpo.c
> 1.11 +2 -1 src/sys/i386/eisa/ahb.c
> 1.7 +1 -0 src/sys/i386/isa/bs/bs.c
> 1.144 +40 -22 src/sys/pci/ncr.c
> 1.5 +2 -1 src/sys/pci/simos.c
>
>
--
e-Mail: hibma@skylink.it
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.990506222513.731D-100000>