From nobody Thu Jul 28 13:42:45 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LtsKT6Vjzz4Xn3P; Thu, 28 Jul 2022 13:42:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4LtsKT4bZgz3w4w; Thu, 28 Jul 2022 13:42:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 26SDgjk0036725 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 28 Jul 2022 16:42:48 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 26SDgjZJ036724; Thu, 28 Jul 2022 16:42:45 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 28 Jul 2022 16:42:45 +0300 From: Konstantin Belousov To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 78ee8d1c4cda - main - qat: Import a new Intel (R) QAT driver Message-ID: References: <202207271514.26RFE53M032558@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on tom.home X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4LtsKT4bZgz3w4w X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Thu, Jul 28, 2022 at 09:37:47AM -0400, Mark Johnston wrote: > On Thu, Jul 28, 2022 at 10:28:16AM +0300, Konstantin Belousov wrote: > > On Wed, Jul 27, 2022 at 03:14:05PM +0000, Mark Johnston wrote: > > > The branch main has been updated by markj: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=78ee8d1c4cdad7a56dbf50f1c8ade75531ce620c > > > > > > commit 78ee8d1c4cdad7a56dbf50f1c8ade75531ce620c > > > Author: Julian Grajkowski > > > AuthorDate: 2022-07-19 08:15:34 +0000 > > > Commit: Mark Johnston > > > CommitDate: 2022-07-27 15:12:35 +0000 > > > > > > qat: Import a new Intel (R) QAT driver > > > > > > QAT in-tree driver ported from out-of-tree release available > > > from 01.org. > > > > > > The driver exposes complete cryptography and data compression > > > API in the kernel and integrates with Open Crypto Framework. > > > Details of supported operations, devices and usage can be found > > > in man and on 01.org. > > > > > > Patch co-authored by: Krzysztof Zdziarski > > > Patch co-authored by: Michal Jaraczewski > > > Patch co-authored by: Michal Gulbicki > > > Patch co-authored by: Julian Grajkowski > > > Patch co-authored by: Piotr Kasierski > > > Patch co-authored by: Adam Czupryna > > > Patch co-authored by: Konrad Zelazny > > > Patch co-authored by: Katarzyna Rucinska > > > Patch co-authored by: Lukasz Kolodzinski > > > Patch co-authored by: Zbigniew Jedlinski > > > > > > Reviewed by: markj, jhb (OCF integration) > > > Reviewed by: debdrup, pauamma (docs) > > > Sponsored by: Intel Corporation > > > Differential Revision: https://reviews.freebsd.org/D34632 > > > > I believe that qat_c2xxx lacks required > > MODULE_DEPEND(qat_c2xxx, firmware, ...) > > dependency line. > > I think you are right. It was missing before though, how did you > notice? I tried to load the qat_c2xxx module on the custom kernel config, where firmware is not included, because it is available as module. > > > I am not sure about qat since it depends on linuxkpi, but perhaps there > > something similar is needed as well. > > Seems so, the new qat uses native firmware(9) interfaces.