From owner-freebsd-bugs@freebsd.org Wed Jun 10 22:52:58 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1D099341A9A for ; Wed, 10 Jun 2020 22:52:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 49j2MG01PSz4g5n for ; Wed, 10 Jun 2020 22:52:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id F2EB1341833; Wed, 10 Jun 2020 22:52:57 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F2AEB341832 for ; Wed, 10 Jun 2020 22:52:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49j2MF67Hbz4gK3 for ; Wed, 10 Jun 2020 22:52:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id CDCAAE5A8 for ; Wed, 10 Jun 2020 22:52:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 05AMqvDT015463 for ; Wed, 10 Jun 2020 22:52:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 05AMqv8A015462 for bugs@FreeBSD.org; Wed, 10 Jun 2020 22:52:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 247129] [PATCH] Fix some compiler warnings in netinet alias module Date: Wed, 10 Jun 2020 22:52:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: nikethmurali@protonmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2020 22:52:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247129 --- Comment #2 from nikethmurali@protonmail.com --- Comment on attachment 215410 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D215410 Patch for /sys/netinet/libalias/alias.c Index: alias.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- alias.c (revision 361967) +++ alias.c (working copy) @@ -443,7 +443,8 @@ IcmpAliasIn(struct libalias *la, struct ip *pip) { struct icmp *ic; - int dlen, iresult; + uint16_t dlen; + int iresult; LIBALIAS_LOCK_ASSERT(la); @@ -740,7 +741,7 @@ { struct udphdr *ud; struct alias_link *lnk; - int dlen; + uint16_t dlen; LIBALIAS_LOCK_ASSERT(la); @@ -839,7 +840,8 @@ u_short dest_port; u_short proxy_server_port; int proxy_type; - int dlen, error; + uint16_t dlen; + int error; LIBALIAS_LOCK_ASSERT(la); @@ -944,7 +946,7 @@ { struct tcphdr *tc; struct alias_link *lnk; - int dlen; + uint16_t dlen; LIBALIAS_LOCK_ASSERT(la); @@ -1069,7 +1071,8 @@ static int TcpAliasOut(struct libalias *la, struct ip *pip, int maxpacketsize, int create) { - int dlen, proxy_type, error; + uint16_t dlen; + int proxy_type, error; u_short dest_port; u_short proxy_server_port; struct in_addr dest_address; @@ -1343,9 +1346,10 @@ static int LibAliasInLocked(struct libalias *la, char *ptr, int maxpacketsize) { - struct in_addr alias_addr; + struct in_addr alias_addr,ip_dst; struct ip *pip; int iresult; + u_short ip_sum ; if (la->packetAliasMode & PKT_ALIAS_REVERSE) { la->packetAliasMode &=3D ~PKT_ALIAS_REVERSE; @@ -1398,14 +1402,24 @@ error =3D find_handler(IN, IP, la, pip, &ad); if (error =3D=3D 0) iresult =3D PKT_ALIAS_OK; - else + else { + ip_dst =3D pip->ip_dst; + ip_sum =3D pip->ip_sum; iresult =3D ProtoAliasIn(la, pip->ip_src,=20 - &pip->ip_dst, pip->ip_p, &pip->ip_sum); + &ip_dst, pip->ip_p, &ip_sum); + pip->ip_dst =3D ip_dst; + pip->ip_sum =3D ip_sum; + } } break;=20 - default: - iresult =3D ProtoAliasIn(la, pip->ip_src, &pip->ip_= dst, - pip->ip_p, &pip->ip_sum); + default: { + ip_dst =3D pip->ip_dst; + ip_sum =3D pip->ip_sum; + iresult =3D ProtoAliasIn(la, pip->ip_src, &ip_dst, + pip->ip_p, &ip_sum); + } + pip->ip_dst =3D ip_dst; + pip->ip_sum =3D ip_sum; break; } @@ -1421,8 +1435,12 @@ } } } else { - iresult =3D FragmentIn(la, pip->ip_src, &pip->ip_dst, pip->= ip_id, - &pip->ip_sum); + ip_dst =3D pip->ip_dst; + ip_sum =3D pip->ip_sum; + iresult =3D FragmentIn(la, pip->ip_src, &ip_dst, pip->ip_id, + &ip_sum); + pip->ip_dst =3D ip_dst; + pip->ip_sum =3D ip_sum; } getout: @@ -1479,8 +1497,9 @@ ) { int iresult; - struct in_addr addr_save; + struct in_addr addr_save,ip_src; struct ip *pip; + u_short ip_sum; if (la->packetAliasMode & PKT_ALIAS_REVERSE) { la->packetAliasMode &=3D ~PKT_ALIAS_REVERSE; @@ -1555,18 +1574,33 @@ error =3D find_handler(OUT, IP, la, pip, &ad); if (error =3D=3D 0) iresult =3D PKT_ALIAS_OK; - else - iresult =3D ProtoAliasOut(la, &pip->ip_src,= =20 - pip->ip_dst, pip->ip_p, &pip->ip_sum, create); + else { + ip_src =3D pip->ip_src; + ip_sum =3D pip->ip_sum; + iresult =3D ProtoAliasOut(la, &ip_src,=20 + pip->ip_dst, pip->ip_p, &ip_sum, create= ); + pip->ip_src =3D ip_src; + pip->ip_sum =3D ip_sum; + } } break; - default: - iresult =3D ProtoAliasOut(la, &pip->ip_src, - pip->ip_dst, pip->ip_p, &pip->ip_sum, create); + default: { + ip_src =3D pip->ip_src; + ip_sum =3D pip->ip_sum; + iresult =3D ProtoAliasOut(la, &ip_src, + pip->ip_dst, pip->ip_p, &ip_sum, create); + pip->ip_src =3D ip_src; + pip->ip_sum =3D ip_sum; + } break; } } else { - iresult =3D FragmentOut(la, &pip->ip_src, &pip->ip_sum); + ip_src =3D pip->ip_src; + ip_sum =3D pip->ip_sum; + iresult =3D FragmentOut(la, &ip_src, &ip_sum); + pip->ip_src =3D ip_src; + pip->ip_sum =3D ip_sum; + } SetDefaultAliasAddress(la, addr_save); --=20 You are receiving this mail because: You are the assignee for the bug.=