From owner-freebsd-current@freebsd.org Sat Sep 19 18:23:47 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 87ECB9CFA85 for ; Sat, 19 Sep 2015 18:23:47 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6917E127D for ; Sat, 19 Sep 2015 18:23:46 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [192.168.100.102] (unknown [50.136.155.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 30A8B193E6A; Sat, 19 Sep 2015 18:23:45 +0000 (UTC) Subject: Re: CURRENT: net/igb broken To: Eric Joyner , "O. Hartmann" , "Pieper, Jeffrey E" References: <20150915125618.0f752596@freyja.zeit4.iv.bundesimmobilien.de> <55F7FCB5.5090809@selasky.org> <2A35EA60C3C77D438915767F458D65688077F87B@ORSMSX111.amr.corp.intel.com> <20150917133509.6c87f5b6@freyja.zeit4.iv.bundesimmobilien.de> <20150917133712.0ffd01ee@freyja.zeit4.iv.bundesimmobilien.de> <55FC40CB.7090504@freebsd.org> Cc: Hans Petter Selasky , freebsd-current From: Sean Bruno Message-ID: <55FDA830.7030307@freebsd.org> Date: Sat, 19 Sep 2015 11:23:44 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Sep 2015 18:23:47 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 09/18/15 10:20, Eric Joyner wrote: > He has an i210 -- he would want to revert e1000_i210.[ch], too. > > Sorry for the thrash Sean -- it sounds like it would be a good idea > for you should revert this patch, and Jeff and I can go look at > trying these shared code updates and igb changes internally again. > We at Intel really could've done a better job of making sure these > changes worked across a wider variety of devices. > > - Eric I've reverted the changes to head. I'll reopen the reviews and we can proceed from there. sean > > On Fri, Sep 18, 2015 at 9:50 AM Sean Bruno > wrote: > > >> >> r287762 broke the system > > > Before I revert this changeset *again* can you test revert r287762 > from if_igb.c, e1000_82575.c and e1000_82575.h *only* > > That narrows down the change quite a bit. > > sean _______________________________________________ > freebsd-current@freebsd.org > mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current To > unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org > " > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJV/agsXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kkkMH/icGgcIAdm3CIxtXtnhbE5E9 N6RrBrgJruoRHP2geJ9UOUGp7MaFwS6AHcwCC7FvxoydzcsT+iMj3Kreu+aEkT4C PZvLsqIvLeX0WVEXSC8jwBAZbrOwJ+4TcMMnW2KZMeUPUHAd8rP0+Skj9AeQ4feJ OfLqv52VdxYTnx+vYbvZSaOgWp8sC+PcoJxiJua7hpmqXwISbcG9eXxQHUil0fcv tqfb2dv89VN12brFuQbFtgEK2RG6gKtbj7IQkeQqzt0g5WL6UnJ5OslajcEJwIA4 H6H4eke5CQUugVTUv5cbCwmQDfAF2qF8JgsxuuQDPvQRb4+XH1ks/5SEhENItv0= =JTMu -----END PGP SIGNATURE-----