From nobody Thu Jul 28 14:04:29 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LtspQ2G6nz4Xqhk; Thu, 28 Jul 2022 14:04:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LtspQ024fz3yKH; Thu, 28 Jul 2022 14:04:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659017070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JsCPnWQC/16/V5zYYNzgO9sJNhIECr+17+cqklhpDtA=; b=fwN2TAwIwhRqXfwcDz9bFr5N57Cl61kbE6ufr0lE6OlPWn2dS7GWbmj14agiBbl40reFtW G86idtX64jcb63MPTL4V/YAPVdrKegOrK6CF9mu40GfIF/aHv2RWJamPrFgoyq2Herj2Ws kqTi0GaHGJFwp9uEqsccPu9qYyk1c8yaaydXELi/u3KeZu0IWpNRJtBcse2TrfdB96fP1v 1fDt1W4a+z4k8SLgCmSf1lmqL3fiXpnKMlZLUxN7lCEJGo2mb2Uij0gx/j5REc3hn+ABxn qdqv6u6hfU0k2hqangi3rG6bzzzZrhuYFe9MkhMfWQSj3sRO6CJKJgRqwIg/XA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4LtspP6FN7zyMq; Thu, 28 Jul 2022 14:04:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26SE4Tpu088961; Thu, 28 Jul 2022 14:04:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26SE4ThH088960; Thu, 28 Jul 2022 14:04:29 GMT (envelope-from git) Date: Thu, 28 Jul 2022 14:04:29 GMT Message-Id: <202207281404.26SE4ThH088960@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: e2fa10e67646 - main - style: Tighten up one use of 'may' List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e2fa10e67646fc754fa352b56ceb38d1ff4cdb5e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659017070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JsCPnWQC/16/V5zYYNzgO9sJNhIECr+17+cqklhpDtA=; b=Aen8csB5lSTQ7UrJcT7GSN8OjmNjFhr6nIDsHXEPVBrPp8kckBzR+tVae/Ww7KG4DBLy/c nTJWU3Fm8TsqYMPHoCHlYRmQbAVqriw3NnW3r1ifJDeML75fDQp8PJc+zD+Olql1r3L2E8 j40aYd2kebfKTk6XPj3G3kQNviQIn+v6PjNB+ufbJseM5mncJqXvDoVKzSTcpe6XtKum3x inkQm94k2gI670IDXgBIiKtqn31fKIyIV9tp71zR9Sj33C0oR3MTFa6WweJ+j5uncpwUlp M2SQTpEvxoYvnrXOXTWl9WKYV2JjOuE3KjlOOX/U8MiNz49PAQFBOz0UZ1JZnQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659017070; a=rsa-sha256; cv=none; b=CdRoL8IHVHTRdtgn4TIXvnkCB3xRkdhkq2qJQe0ZC8Y9Lg8GW1UCKG7QjiV0VL+H/0tq0W laPyp550wTB9VoiyJzPcHsOPWMlADr9xhF+P/C6DQ9nXHiRiS1JmO6k5/Z0KGtpm0edtwv GSXF0gNQIKrOWbJRdHUxcTup31ILjnsui66D7tq9A9OPTKnKCuYjz8K4E9+WUNfbOXzdQ6 AfDTnBrQhbHQd1Ktuz0mfyWPDw4A97Xdw9z/yJbi1WYI7AUHiADQszbY0KJaxNW+QcAfvI PKV0t0EeoAOtLWWM6Ga+XZ5oAnKh43sbrSFgP1jttx7ghUa39IzBxFy+1Wq+Nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=e2fa10e67646fc754fa352b56ceb38d1ff4cdb5e commit e2fa10e67646fc754fa352b56ceb38d1ff4cdb5e Author: Warner Losh AuthorDate: 2022-07-28 14:01:09 +0000 Commit: Warner Losh CommitDate: 2022-07-28 14:01:54 +0000 style: Tighten up one use of 'may' Declarations of variables must be placed before the statements of a block, by convention. Use 'must' instead of 'may' here and clarify langauge. Sponsored by: Netflix Reviewed by: pstef, rpokala, hselasky Differential Revision: https://reviews.freebsd.org/D35959 --- share/man/man9/style.9 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/share/man/man9/style.9 b/share/man/man9/style.9 index 4ef0c0a8b4bb..64fcc7425b4e 100644 --- a/share/man/man9/style.9 +++ b/share/man/man9/style.9 @@ -701,8 +701,7 @@ then in alphabetical order; multiple ones per line are okay. If a line overflows reuse the type keyword. Variables may be initialized where declared especially when they are constant for the rest of the scope. -Declarations may be placed before executable lines at the start -of any block. +Declarations may be in any block, but must be placed before statements. Calls to complicated functions should be avoided when initializing variables. .Bd -literal struct foo one, *two;