From owner-freebsd-arm@FreeBSD.ORG Wed Dec 10 23:11:01 2014 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9CA097E7 for ; Wed, 10 Dec 2014 23:11:01 +0000 (UTC) Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6BBC8284 for ; Wed, 10 Dec 2014 23:11:01 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id lf10so3148265pab.32 for ; Wed, 10 Dec 2014 15:11:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=Z0h0NnzJuR1Bh7tFv0QeJPYyiCmdFcoig9riOBY0+kM=; b=leUJlHvCGvGci/oN/FomEsutTtax2jlRunvt56Be5xpaykCIJ/bouK3099c7F4mHHM 0qlDqjU0gexdGMlvUvlvhl1VtjQdoorJPVv/2T9nctqI1ZQOaBT0EfO7Fu/bUJQw+cm5 uzSCO4dRYAMzlnnytZODIvWMb1cPeJ9r0F10lTbI+FBFwTT7BjICnfQNhycYDsOauo3W x7YVxWW5ypD3Su/DHZD28B53BOhcU4fhWum5JySBvW1bKH61KOxgXMI8aTiPvbU+TouR r4hJ+/EC0xX3qJ4NtC3dbTU8s/9zTLACLI55pR1bo+tzTKNKMUmAV8DsznZ1nmz8qkZo BCWQ== X-Gm-Message-State: ALoCoQkQf+L1L9M466/onTXSd8YZvl4KcyO0XL59te+9phMRfLZnAQrTzlBQ4K6aAHItQvC8/NVB X-Received: by 10.70.103.37 with SMTP id ft5mr11275753pdb.159.1418253060390; Wed, 10 Dec 2014 15:11:00 -0800 (PST) Received: from lgmac-vviswanat.corp.netflix.com ([69.53.236.236]) by mx.google.com with ESMTPSA id l13sm5145982pbq.40.2014.12.10.15.10.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 10 Dec 2014 15:10:59 -0800 (PST) Sender: Warner Losh Subject: Re: Minor fixes to PL011 UART Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: multipart/signed; boundary="Apple-Mail=_310C6935-4283-43A8-9752-ECC0BB94C41F"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b3 From: Warner Losh In-Reply-To: Date: Wed, 10 Dec 2014 15:10:57 -0800 Message-Id: References: To: Zbigniew Bodek X-Mailer: Apple Mail (2.1993) Cc: "freebsd-arm@freebsd.org" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2014 23:11:01 -0000 --Apple-Mail=_310C6935-4283-43A8-9752-ECC0BB94C41F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Dec 10, 2014, at 2:14 PM, Zbigniew Bodek wrote: >=20 > <0001-Fix-some-obvious-mistakes-in-ARM-PL011-UART.patch> This looks good to me, assuming that the busy bit you are testing is = well defined for all implementations of pl011. I=E2=80=99d consider = adding the uart_barrier, but it isn=E2=80=99t critical. Warner --Apple-Mail=_310C6935-4283-43A8-9752-ECC0BB94C41F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUiNMCAAoJEGwc0Sh9sBEAHgEP+wXXsf1KsikCnJGWTM2juCvL zN/kR1uQrOLP2oAOUti5x8gBvX9k35JITPmcXrUp+q4EcLRRUWwzrzsuB15U+y1w +IDsbJ7Ixz/zMLRi+IUltKVLSa+58Xj0ovC7vNDikYhDefcnUDeXKg6yGv5hQWOg UrEfOMg5Z5yJkIRh1N3ct5mA4+1CU2f5csBucZYS3ss9YWBb7AnrZ8P6vJQVL9vx U0l158/GKVDirRY8XIrdnYyB1d7VMD1/uGj3UXI1+Kv16Z7JeSo4U9jeSQ0IqNki xLZnxPdh1GRUFoFHXpOly7HCrMG1VBDiFdqib6BhwOdcofnI+uRL9hjlypu23dQW e4K5aVTBgg96vrD7Na0a6UVeEKlERTPdg+dzHo/NnqN0Zj0ytKIipasBL11ZwgHR 7A3XnAR//n0M0WI/6c86FoGnb6X5WuDscBLQbuwT3Ik+KbN3QK8/7apLuqtW4SZg bF+lZUEPeoySk12w3jJNhYmWNTMLddxqa48atc3AO+PkqnZVw/gkrwhFPlz8Yrly FhXpHwT7ZlhbPWiFwgc2WYwWJFLg7KdbMmPYdGGolV5MZ3xmdcmNYP8cZ3wito51 dYJdb7axsWu7NeRadSkbQmbFA7IO05j3b40KE1D/AowWvONBt/ju61o4Zmc8p79i X0SfUdpwnDkOHTfmcC+o =5odH -----END PGP SIGNATURE----- --Apple-Mail=_310C6935-4283-43A8-9752-ECC0BB94C41F--