From owner-freebsd-stable@FreeBSD.ORG Wed May 11 03:43:58 2005 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7463616A4CE; Wed, 11 May 2005 03:43:58 +0000 (GMT) Received: from aldan.algebra.com (aldan.algebra.com [216.254.65.224]) by mx1.FreeBSD.org (Postfix) with ESMTP id 94C4143D54; Wed, 11 May 2005 03:43:57 +0000 (GMT) (envelope-from mi+mx@aldan.algebra.com) Received: from corbulon.video-collage.com (static-151-204-231-237.bos.east.verizon.net [151.204.231.237]) by aldan.algebra.com (8.13.1/8.13.1) with ESMTP id j4B3htxm083022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 May 2005 23:43:56 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) Received: from vaio.virtual-estates.net (aldan.algebra.com [216.254.65.224]) j4B3hmQO079763 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 May 2005 23:43:49 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) Received: from vaio.virtual-estates.net (localhost [127.0.0.1]) j4B3hhBC000818; Tue, 10 May 2005 23:43:43 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) Received: from localhost (localhost [[UNIX: localhost]]) by vaio.virtual-estates.net (8.13.3/8.13.3/Submit) id j4B3hgI8000817; Tue, 10 May 2005 23:43:42 -0400 (EDT) (envelope-from mi+mx@aldan.algebra.com) X-Authentication-Warning: vaio.virtual-estates.net: mi set sender to mi+mx@aldan.algebra.com using -f From: Mikhail Teterin To: Daniel Eischen Date: Tue, 10 May 2005 23:43:41 -0400 User-Agent: KMail/1.8 References: In-Reply-To: X-Face: %UW#n0|w>ydeGt/b@1-.UFP=K^~-:0f#O:D7whJ5G_<5143Bb3kOIs9XpX+"V+~$adGP:J|SLieM31VIhqXeLBli"<=?koi8-u?q?kcG=5EEOVihy+z3/UR=7B6SCQ=0A?= MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-u" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200505102343.42387@Misha> X-Virus-Scanned: clamd / ClamAV version devel-20040615, clamav-milter version 0.73a on corbulon.video-collage.com X-Virus-Status: Clean X-Scanned-By: MIMEDefang 2.43 cc: stable@freebsd.org cc: re@freebsd.org Subject: Re: PTHREAD_INVARIANTS in 5.x X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2005 03:43:58 -0000 = > As we were counting down to 5.3-RELEASE, I noticed, that all = > threading libraries still compile with PTHREAD_INVARIANTS. My = > suggestion to have this = > fixed was shutdown as not enough time = > was left for testing the 5.3. = > Can we have these things turned off NOW, so that, at least, 5.5 = > stands a chance? Thanks! = = What makes you think there is a measurable performance impact with = them on? Interesting... Are you implying, the debugging code makes no difference, or are genuinly asking? There are additional steps in the code, that are only done when the define is on. Does not look like much in libthr, but c_r's uthread/uthread_mutex.c seems quite affected, for example. And you know it, of course... = Regardless, it would first need to be in -current, not -stable. I thought, the debugging features (WITNESS INVARIANTS) are always on in -current, but are turned off in -stable for maximum performance. Is that no longer true? -mi