Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 May 2015 03:17:33 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r282445 - stable/10/sys/netinet6
Message-ID:  <201505050317.t453HXp2082532@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Tue May  5 03:17:32 2015
New Revision: 282445
URL: https://svnweb.freebsd.org/changeset/base/282445

Log:
  MFC r281483:
  Fix a possible refcount leak in regen_tmpaddr().

Modified:
  stable/10/sys/netinet6/nd6.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/netinet6/nd6.c
==============================================================================
--- stable/10/sys/netinet6/nd6.c	Tue May  5 03:13:02 2015	(r282444)
+++ stable/10/sys/netinet6/nd6.c	Tue May  5 03:17:32 2015	(r282445)
@@ -757,11 +757,10 @@ regen_tmpaddr(struct in6_ifaddr *ia6)
 		 * address with the prefix.
 		 */
 		if (!IFA6_IS_DEPRECATED(it6))
-		    public_ifa6 = it6;
-
-		if (public_ifa6 != NULL)
-			ifa_ref(&public_ifa6->ia_ifa);
+			public_ifa6 = it6;
 	}
+	if (public_ifa6 != NULL)
+		ifa_ref(&public_ifa6->ia_ifa);
 	IF_ADDR_RUNLOCK(ifp);
 
 	if (public_ifa6 != NULL) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201505050317.t453HXp2082532>