From owner-freebsd-current@FreeBSD.ORG Wed Oct 8 09:16:22 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D1D61065694 for ; Wed, 8 Oct 2008 09:16:22 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id DE9DB8FC23 for ; Wed, 8 Oct 2008 09:16:21 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (pD9E2F246.dip.t-dialin.net [217.226.242.70]) by redbull.bpaserver.net (Postfix) with ESMTP id 143D12E0A5; Wed, 8 Oct 2008 11:16:15 +0200 (CEST) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 3D85E67749; Wed, 8 Oct 2008 11:15:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1223457353; bh=7t5rA859sWI9faZ4MxQkfPdebk13E9SKN LBHi4hbJHI=; h=Message-ID:Date:From:To:Cc:Subject:References: In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=ko0w38WhkjHAdK/wyx/rFJxqzKBlm8BRpwqS8RiqXu1UfLgIPaw2pisFwHU5DT2pV NRi5oQZZa8/e6oed6ykqUp5Lrz+zstz50TiyK5QqGdojq5HexT3P+xjOZRBydDNIJni q8JhueN7edt8jrzdcVxkFRmtcO0aIe7QwTwR0G2D5W7HNWSNv4pdbsm766VR6mTXDNS tFjxkLIzRcZgFIcWX0HUBmqXWIMNkrDYWnrz8EZZDTJ5SxuvMnfvUnG7ct6o0cxZefV cX4ydSWYZQBh5aMWgduLLJVZJO6r8HXeh5XC1zwdOkRcLkD1w+g3LiGCBPUTDsY9VuF 76RXZx0Ug== Received: (from www@localhost) by webmail.leidinger.net (8.14.2/8.13.8/Submit) id m989FqnZ003402; Wed, 8 Oct 2008 11:15:52 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 08 Oct 2008 11:15:52 +0200 Message-ID: <20081008111552.69843ndq7vkp4hgk@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 08 Oct 2008 11:15:52 +0200 From: Alexander Leidinger To: Poul-Henning Kamp References: <56363.1223454787@critter.freebsd.dk> In-Reply-To: <56363.1223454787@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.3) / FreeBSD-8.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-MailScanner-ID: 143D12E0A5.7601F X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, ORDB-RBL, SpamAssassin (not cached, score=-12.904, required 6, BAYES_00 -15.00, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00, J_CHICKENPOX_52 0.60, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: current@freebsd.org Subject: Re: umass quirk review ? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Oct 2008 09:16:22 -0000 Quoting Poul-Henning Kamp (from Wed, 08 Oct 2008 =20 08:33:07 +0000): > > I'm vaguely aware that we have some admin process in place for reviewing > quirkentries in umass, but I seem unable to find out who to send my > patch to ? AFAIR the process is to register a PR so that we have a trace. The PR =20 should give infos about the device and the problems without the =20 quirks, and ideally why each quirk is needed for this device ("quirk A =20 solves error X and quirk B solves error Y" or something like this). After that feel free to commit and close the PR. Bye, Alexander. > Unless anybody objects, this goes in soonish. > > And yes, an infrared camera is a neat toy: > > =09http://phk.freebsd.dk/misc/misling.png > > Poul-Henning > > > Index: usbdevs > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- usbdevs=09(revision 183674) > +++ usbdevs=09(working copy) > @@ -1855,6 +1855,7 @@ > product OMNIVISION OV511PLUS=090xa511=09OV511+ Camera > > /* OnSpec Electronic, Inc. */ > +product ONSPEC SDS_HOTFIND_D=090x0400=09SDS-infrared.com Hotfind-D =20 > Infrared Camera > product ONSPEC MDCFE_B_CF_READER=090xa000=09MDCFE-B USB CF Reader > product ONSPEC CFMS_RW=09=090xa001=09SIIG/Datafab Memory Stick+CF Reader/= Writer > product ONSPEC READER=09=090xa003=09Datafab-based Reader > Index: umass.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- umass.c=09(revision 183674) > +++ umass.c=09(working copy) > @@ -610,6 +610,10 @@ > =09 UMASS_PROTO_SCSI, > =09 NO_QUIRKS > =09}, > +=09{ USB_VENDOR_ONSPEC, USB_PRODUCT_ONSPEC_SDS_HOTFIND_D, RID_WILDCARD, > +=09 UMASS_PROTO_SCSI | UMASS_PROTO_BBB, > +=09 NO_GETMAXLUN | NO_SYNCHRONIZE_CACHE > +=09}, > =09{ USB_VENDOR_ONSPEC, USB_PRODUCT_ONSPEC_MDCFE_B_CF_READER, RID_WILDCAR= D, > =09 UMASS_PROTO_SCSI, > =09 NO_QUIRKS > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence= . > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > --=20 I'm definitely not in Omaha! http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137