From owner-cvs-src@FreeBSD.ORG Wed Mar 26 02:38:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A899B37B404; Wed, 26 Mar 2003 02:38:18 -0800 (PST) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id 0A1F544001; Wed, 26 Mar 2003 02:38:05 -0800 (PST) (envelope-from iedowse@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 26 Mar 2003 10:38:03 +0000 (GMT) To: Alfred Perlstein In-Reply-To: Your message of "Tue, 25 Mar 2003 17:46:11 PST." <200303260146.h2Q1kBbE031907@repoman.freebsd.org> Date: Wed, 26 Mar 2003 10:38:03 +0000 From: Ian Dowse Message-ID: <200303261038.aa94448@salmon.maths.tcd.ie> X-Spam-Status: No, hits=-11.4 required=5.0 tests=AWL,EMAIL_ATTRIBUTION,IN_REP_TO version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Mar 2003 10:38:20 -0000 In message <200303260146.h2Q1kBbE031907@repoman.freebsd.org>, Alfred Perlstein writes: > Modified files: > sys/nfsclient nfs_socket.c > Log: > req can not be NULL or we'd die. I think the NULL checks were left over from revision 1.50 of nfs_socket.c and then later extended (by me). Before 1.50, nfs_sndlock() could be called with req == NULL, but the tests can safely be removed now as you have done. Ian