From owner-svn-src-head@freebsd.org Tue Aug 27 01:33:45 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 25BC1C3BFE; Tue, 27 Aug 2019 01:33:45 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46HWc81Brnz49yh; Tue, 27 Aug 2019 01:33:43 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-oi1-x234.google.com with SMTP id o6so13671435oic.9; Mon, 26 Aug 2019 18:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W6hlwlQRev3D/J6RJj43HtGFrLvZhpRkme9+vXIn61c=; b=jcf5hOyUQwBj43nkvV3KtZoVDbSWiHVrM2VtY8nNSOpZlWVGDR/o+HRiyMXgnnZPEP AHY/SnDamyslgE6rbLwCJaVLRAPvP9qiAuN2skTYQ3POyPFLF7GsA5ea/aZv51gHp0E8 9/6LCVhBMAqkZCmJqU1AgcP5x9bHo1rP/ZxVaSS/0wNPOXvC8qg3I5A3tLuZD/nZ0Vkr ewUzykEONRWF6EyaldYh/sTFwQYg9rDgW2xKU4+tJuryP5zwD8i0+WrWThDfFCEhaGdb VhZrupnbEwYPqJEeGxgYa01tz5RTV5wXb+IfAfrTtctE9EpjOp9Xhoxq8BSVEjYMmq4d 5FoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=W6hlwlQRev3D/J6RJj43HtGFrLvZhpRkme9+vXIn61c=; b=a/3NDWStVGz2/rTVrSZC9hDdZHnXPhy6Vsul0gKEo5oRVSow5+Z/uDYiNJDQxhrXTc 3XNFbepzci9+PYlo9ZSh9yrk0TqZUtxVo8sf9o836VTPR6Qa67Wkwrn+suAv71x4TLzz k6tRX/ChQmH6i927BEC78ASnDsgFTwluYCWF5Uhf7Inyp/t5ZBfE5yDbG38A2EPE9zZw 9fRFu5zOyrnryTDrQYg7amQhqYcr2PJrGKpcEw62qz7JIzaRw/3fDl/nHrj2tuNz0ZAY pDF8B0B/wDsUxGk+SRpoeTVP2AY1nWDsF+CQHBz39RDarmOIpEvcPT5an2zLRwVNuSEF lQQQ== X-Gm-Message-State: APjAAAW4K1rRkCxPCszlFTbFqrgOJhEFyIlWfggXKdba0lEFtskW3UqO SXB1iMoqa6q3uhgvnNvdFUcDCDt8LeE= X-Google-Smtp-Source: APXvYqx7Imlu0ZBkbA4tJ59gcBZ07gAFB+PXWdSXrFQagcxA6dhyYowN488ClF/B2G+mW9t7jeo8yA== X-Received: by 2002:aca:2809:: with SMTP id 9mr14506330oix.163.1566869622061; Mon, 26 Aug 2019 18:33:42 -0700 (PDT) Received: from spectre.mavhome.dp.ua ([2600:1700:3580:3560:228:f8ff:fe04:d12]) by smtp.gmail.com with ESMTPSA id e2sm4665091otl.67.2019.08.26.18.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2019 18:33:41 -0700 (PDT) Sender: Alexander Motin Subject: Re: svn commit: r351514 - head/sys/dev/pci To: cem@freebsd.org Cc: src-committers , svn-src-all , svn-src-head References: <201908261727.x7QHRbsc020978@repo.freebsd.org> From: Alexander Motin Autocrypt: addr=mav@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFOzxAwBCADkPrax0pI2W/ig0CK9nRJJwsHitAGEZ2HZiFEuti+6/4UVxj81yr4ak/4g 9bKUyC7rMEAp/ZHNhd+MFCPAAcHPvtovnfykqE/vuosCS3wlSLloix2iKVLks0CwbLHGAyne 46lTQW74Xl/33c3W1Z6d8jD9gVFT/xaVzZ0U9xdzOmsYAZaAj4ki0tuxO9F7L+ct9grRe7iP g8t9hai7BL4ee3VRwk2JXnKb7UvBiVITKYWKz1jRvZIrjPokgEcCLOSlv7x/1kjuFnj3xWZU 7HSFFT8J93epBbrSSCsYsppIk2fZH41kaaFXsMQfTPH8wkeM6qwrvOh4HiQM08R+9tThABEB AAG0IUFsZXhhbmRlciBNb3RpbiA8bWF2QEZyZWVCU0Qub3JnPokBVwQTAQoAQQIbAwULCQgH AwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMKuBQkN McyiAAoJEIMYw5VbqyJ/tuUIAOG3ONOSNYqjK4eTZ1TVh9jdUBAhWk5nhDFnODN49Wj0AbYm 7aIqy8O1hnCDSZG5LttjSAo3UfXJZDKQM0BLb0gpRMBnAYqO6tdolLNqAbPGJBnGoPjsh24y 6KcbDaNnis+lD4GwPXwQM+92wZGhCUFElPV9NciZGVS65TNIgk7X+yEjjhD1MSWKKijZ1r9Z zIt4OzUTxxNOvzdlABZS88nNRdJkatOQJPmFdd1mpP6UzTNCiLUo1pIqOEtJgvVVDYq5WHY6 tciWWYdmZG/tIBexJmv2mV2OLVjXR6ZeKmntVH14H72/wRHJuYHQC+r5SVRcWWayrThsY6jZ Yr4+raS5AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6Z AXgDtmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8Flv mI/c40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt 3ytU8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZ R1EdEIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm5 9R8AEQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczM AAoJEIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLq A6xe6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHu uC5vgPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15Gc sS9YcQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9 TevwGsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCg lz65AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6ZAXgD tmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8FlvmI/c 40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt3ytU 8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZR1Ed EIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm59R8A EQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczMAAoJ EIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLqA6xe 6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHuuC5v gPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15GcsS9Y cQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9Tevw Gsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCglz4= Message-ID: <38e64dee-013a-f46e-0937-8834dc6065aa@FreeBSD.org> Date: Mon, 26 Aug 2019 21:33:40 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 46HWc81Brnz49yh X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=jcf5hOyU; dmarc=none; spf=pass (mx1.freebsd.org: domain of mavbsd@gmail.com designates 2607:f8b0:4864:20::234 as permitted sender) smtp.mailfrom=mavbsd@gmail.com X-Spamd-Result: default: False [-6.00 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-2.82)[ip: (-8.84), ipnet: 2607:f8b0::/32(-2.86), asn: 15169(-2.33), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; RCVD_IN_DNSWL_NONE(0.00)[4.3.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FORGED_SENDER(0.30)[mav@FreeBSD.org,mavbsd@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[mav@FreeBSD.org,mavbsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Aug 2019 01:33:45 -0000 On 26.08.2019 18:00, Conrad Meyer wrote: > On Mon, Aug 26, 2019 at 10:27 AM Alexander Motin wrote: >> >> Author: mav >> Date: Mon Aug 26 17:27:36 2019 >> New Revision: 351514 >> ... >> - device_printf(dev, >> - "HotPlug Command Timed Out - forcing detach\n"); >> - sc->flags &= ~(PCIB_HOTPLUG_CMD_PENDING | PCIB_DETACH_PENDING); >> - sc->flags |= PCIB_DETACHING; >> - pcib_pcie_hotplug_update(sc, 0, 0, true); >> + device_printf(dev, "HotPlug Command Timed Out\n"); >> + sc->flags &= ~PCIB_HOTPLUG_CMD_PENDING; > > If this case is expected (and it seems like it is, at least in > relatively common hardware), and the kernel isn't taking an action > based on it anymore (formerly, it would then cause detach), is there > any reason to print a message at all? What information should a user > glean from the message, or what action should be taken? It seems like > Nothing and None, respectively. So perhaps it is better to not print > anything in this case? Or maybe mask it behind bootverbose. While you may be right, for now I would leave it visible just to show that something went wrong, in case somebody wish to diagnose some real issue that may have same symptoms. It is just one line per event, so it should not be too annoying. Most people will never see it, since PCIe hot-plug is still very rare. On the mentioned Supermicro board ACPI actually blocks hot-plug support, since FreeBSD does not announce ASPM capability. This is the next real issue we need to think about. Cosmetics will follow later. -- Alexander Motin