From owner-cvs-all  Wed Mar 19 21:45: 7 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1367937B401; Wed, 19 Mar 2003 21:45:05 -0800 (PST)
Received: from HAL9000.homeunix.com (12-233-57-224.client.attbi.com [12.233.57.224])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2041543FDF; Wed, 19 Mar 2003 21:45:04 -0800 (PST)
	(envelope-from das@FreeBSD.org)
Received: from HAL9000.homeunix.com (localhost [127.0.0.1])
	by HAL9000.homeunix.com (8.12.6/8.12.5) with ESMTP id h2K5j3mR004539;
	Wed, 19 Mar 2003 21:45:03 -0800 (PST)
	(envelope-from das@FreeBSD.org)
Received: (from das@localhost)
	by HAL9000.homeunix.com (8.12.6/8.12.5/Submit) id h2K5j2mF004538;
	Wed, 19 Mar 2003 21:45:02 -0800 (PST)
	(envelope-from das@FreeBSD.org)
Date: Wed, 19 Mar 2003 21:45:02 -0800
From: David Schultz <das@FreeBSD.org>
To: "Andrey A. Chernov" <ache@nagual.pp.ru>
Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/contrib/gdtoa gdtoaimp.h
Message-ID: <20030320054502.GA4308@HAL9000.homeunix.com>
Mail-Followup-To: "Andrey A. Chernov" <ache@nagual.pp.ru>,
	src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200303192025.h2JKPjNr000550@repoman.freebsd.org> <20030320050712.GA48184@nagual.pp.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030320050712.GA48184@nagual.pp.ru>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Thus spake Andrey A. Chernov <ache@nagual.pp.ru>:
> On Wed, Mar 19, 2003 at 12:25:45 -0800, David Schultz wrote:
> >   Log:
> >   Enable locale support in strtod() and dtoa().
> >   
> >   Noticed by:     ache
> >   Reviewed by:    mike (mentor)
> 
> It seems that locale implementation is not complete - see
> gethex.c:gethex() '.' processing (must be actual decimal point here). The
> fix is obvious (like in other places).

Good catch.  Fortunately nobody relies upon hexadecimal floating
point constants at the moment.  (Before I sent the vendor some
patches, strtod() would actually core dump when it saw them!)  Do
you see anything else I should bug the vendor about while I'm at
it?  As you can tell, I don't often use anything other than the C
locale.  I think we're the first to integrate a modern version of
David Gay's library into a full-blown operating system, so we get
to stumble across all the nits.  :(

> The next thing is style: why
> #include "locale.h"
> instead of
> #include <locale.h> ?

With one exception, the author uses that convention consistently.
I imagine it would be convenient if an integrator wanted to
override one of the standard system headers.  Whatever his reason
may be, it shouldn't hurt anything.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message