From owner-svn-src-stable@freebsd.org Thu Aug 16 01:02:02 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F0AB1076803; Thu, 16 Aug 2018 01:02:02 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0C50185D5C; Thu, 16 Aug 2018 01:02:01 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w7G11x16051009; Wed, 15 Aug 2018 18:01:59 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w7G11wZD051008; Wed, 15 Aug 2018 18:01:58 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201808160101.w7G11wZD051008@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r337826 - stable/11/bin/ls In-Reply-To: To: Kyle Evans Date: Wed, 15 Aug 2018 18:01:58 -0700 (PDT) CC: "Rodney W. Grimes" , Adam Weinberger , svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers , Ed Maste , svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 01:02:02 -0000 > On Wed, Aug 15, 2018 at 2:55 PM, Rodney W. Grimes > wrote: > >> On Wed, Aug 15, 2018 at 2:34 PM, Rodney W. Grimes > >> wrote: > >> > [ Charset UTF-8 unsupported, converting... ] > >> >> On Wed, Aug 15, 2018 at 12:43 PM, Rodney W. Grimes > >> >> wrote: > >> >> > > >> >> > From the Linux man page at: http://man7.org/linux/man-pages/man1/ls.1.html > >> >> > > >> >> > Using color to distinguish file types is disabled both by default and > >> >> > with --color=never. With --color=auto, ls emits color codes only > >> >> > when standard output is connected to a terminal. The LS_COLORS > >> >> > environment variable can change the settings. Use the dircolors > >> >> > command to set it. > >> >> > > >> >> > Um, so by default we should not be doing any colour... and we are... > >> >> > > >> >> > >> >> I don't recall making any argument that we're trying to match GNU > >> >> ls(1) behavior. Furthermore, again, we aren't doing any color by > >> >> default- only when the COLORTERM environment variable is set. > >> > > >> > So we are intentially being different? > >> > > >> > >> No, we are not intentionally being different. See: the next paragraph, > >> where I described that we've now-historically been honoring an > >> environment variable for this and have simply added a more standard > >> name for this variable. > > > > And one that is set by default many more places than the one that > > had been set before, changing behavior people have been seeing for > > a long time, and some of those people did not expect that, > > nor seem to want it either. > > Will backing out the MFC and leaving this a 12.0 feature end this? =( >From some other private discussion with Warner I think it may be wise at this time to revert the MFC until some other things are done in 12.0 to address some of the concerns and merge a more complete solution. Thanks, Rod -- Rod Grimes rgrimes@freebsd.org