From owner-freebsd-current@FreeBSD.ORG  Fri Jan  3 11:33:45 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0E3E2C1A;
 Fri,  3 Jan 2014 11:33:45 +0000 (UTC)
Received: from SMTP02.CITRIX.COM (smtp02.citrix.com [66.165.176.63])
 (using TLSv1 with cipher RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 617251389;
 Fri,  3 Jan 2014 11:33:42 +0000 (UTC)
X-IronPort-AV: E=Sophos;i="4.95,597,1384300800"; d="scan'208";a="87315541"
Received: from accessns.citrite.net (HELO FTLPEX01CL01.citrite.net)
 ([10.9.154.239])
 by FTLPIPO02.CITRIX.COM with ESMTP; 03 Jan 2014 11:33:40 +0000
Received: from [IPv6:::1] (10.80.16.47) by smtprelay.citrix.com (10.13.107.78)
 with Microsoft SMTP Server id 14.2.342.4;
 Fri, 3 Jan 2014 06:33:39 -0500
Message-ID: <52C6A013.1070906@citrix.com>
Date: Fri, 3 Jan 2014 12:33:39 +0100
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Julian Elischer <julian@freebsd.org>, <freebsd-xen@freebsd.org>,
 <freebsd-current@freebsd.org>, <xen-devel@lists.xen.org>,
 <gibbs@freebsd.org>, <jhb@freebsd.org>, <kib@freebsd.org>,
 <julien.grall@citrix.com>
Subject: Re: [PATCH v9 19/19] isa: allow ISA bus to attach to xenpv device
References: <1388677433-49525-1-git-send-email-roger.pau@citrix.com>
 <1388677433-49525-20-git-send-email-roger.pau@citrix.com>
 <52C602B0.7060904@freebsd.org>
In-Reply-To: <52C602B0.7060904@freebsd.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-DLP: MIA1
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jan 2014 11:33:45 -0000

On 03/01/14 01:22, Julian Elischer wrote:
> On 1/2/14, 4:43 PM, Roger Pau Monne wrote:
>> ---
>>   sys/x86/isa/isa.c |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/sys/x86/isa/isa.c b/sys/x86/isa/isa.c
>> index 1a57137..9287ff2 100644
>> --- a/sys/x86/isa/isa.c
>> +++ b/sys/x86/isa/isa.c
>> @@ -241,3 +241,6 @@ isa_release_resource(device_t bus, device_t child,
>> int type, int rid,
>>    * On this platform, isa can also attach to the legacy bus.
>>    */
>>   DRIVER_MODULE(isa, legacy, isa_driver, isa_devclass, 0, 0);
>> +#ifdef XENHVM
>> +DRIVER_MODULE(isa, xenpv, isa_driver, isa_devclass, 0, 0);
>> +#endif
> read all 19 patches. I'm glad you split them up.. makes it
> understandable.. even by me :-)
> no real negative comments except a question as to whether there is any
> noticable performance impact on real hardware?

Thanks for taking a look. I haven't seen any performance impact when
running a PVH capable kernel (a kernel with this patch series applied)
on real hardware. I'm not adding hooks to any hot paths, most of the
code added in this series is only used during boot time.

Roger.