From owner-svn-src-all@freebsd.org Mon Feb 5 21:32:06 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C79BEF1ACF; Mon, 5 Feb 2018 21:32:06 +0000 (UTC) (envelope-from jason.harmening@gmail.com) Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA4D18A8B3; Mon, 5 Feb 2018 21:32:05 +0000 (UTC) (envelope-from jason.harmening@gmail.com) Received: by mail-it0-x22c.google.com with SMTP id k6so256881ita.3; Mon, 05 Feb 2018 13:32:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RzJuzoNnBwCPQfEG5h1GskVDsbU3gF6YUlhuW5V/qmk=; b=nSrqlTvZvM/7RFTHhZ0JfaZd1HfReniUuVOftLPZsfIUeJYUOqRIvEom4LEAdD4//B /+PLGKnbnjmxV2gQ0TRu5m4s7JjK8LiFcdJgfsctW6WpR1pwGiaQ+HVNe8U7Y+EKTSSw lHywk+xKA0E8pcnbS+Ykk2+fk9iVdA7cbcTj3/8W8gIOZIDJW2sd4iG6MQqslv1mXXBh +4KC7saq1Ji+tHxv4XlPmZnZ3QFDbCgnmUV7MLe379HzbZxkfNA1AhxX9BHY/8MNpvyy U14RCDCKuU/Cl1EJXOcunBDJGRqgN9jDxUCojvtS4yM7Av1ztU+6jkGLExuf3Ob3F1L+ f06Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RzJuzoNnBwCPQfEG5h1GskVDsbU3gF6YUlhuW5V/qmk=; b=hkc4imUNRfjOlFwdmEF4zLy0wGX9EQKkRWYyGnryq9U7d2j4ie+cl2+svdc2iYqQ+X AV6lYs2ellbNFhMV8xvgI03EXC5Pt7t9UIw4OGlB54DNzTiQEXMV3AmqxrHBUIKKGNr7 zJo6hELCA17hEbK84+qqqhtAjGEk8fGhmQ4zJDRGsaQZAE2prVXI0DL6ivR8MRJQzb3G XeFly9gv5toUiSZine0dGhjeBLVnzT1ht1x97sgXU6Iv1J8+q99LnVby4cxMurFk5Ayz 3bE3cwq2wJgTwKUkHAy549L6hCM7rZoZptDARQpqAWNYl5sZ47YwIbu8THl24T0UxEc4 tasg== X-Gm-Message-State: APf1xPAmpPtBuOJAa7AUHlMEaUP7l7V4SRv+3NlQZPqPIh4wZW9lNgna 1yDK5ujhwGXjTkienzTVXm5Rw6hQOe+ExcJ7OjIA X-Google-Smtp-Source: AH8x227dPf19eM1quuyajdFueH4/wCfNBmJuVpu6Sb78C2Jg4hAnp0tJB8GNYzH2pDT3VSnjfm8YOk9rTxFnMEyGCjA= X-Received: by 10.36.2.213 with SMTP id 204mr179660itu.121.1517866324996; Mon, 05 Feb 2018 13:32:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.136.103 with HTTP; Mon, 5 Feb 2018 13:32:04 -0800 (PST) In-Reply-To: <20180205222622.43f5d3e7@thor.intern.walstatt.dynvpn.de> References: <201801272013.w0RKDaMU098200@repo.freebsd.org> <20180127214755.3c59661e@thor.intern.walstatt.dynvpn.de> <98501f75-1a1b-9221-c52d-24415230a886@gmail.com> <20180129130022.GT1125@albert.catwhisker.org> <20180204133337.3d03f01d@thor.intern.walstatt.dynvpn.de> <20180205222622.43f5d3e7@thor.intern.walstatt.dynvpn.de> From: Jason Harmening Date: Mon, 5 Feb 2018 13:32:04 -0800 Message-ID: Subject: Re: svn commit: r328489 - head/sys/conf To: "O. Hartmann" Cc: David Wolfskill , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 21:32:06 -0000 On Mon, Feb 5, 2018 at 1:25 PM, O. Hartmann wrote: > Am Sun, 4 Feb 2018 10:22:31 -0800 > Jason Harmening schrieb: > > > On 02/04/18 04:33, O. Hartmann wrote: > > > Am Mon, 29 Jan 2018 05:00:22 -0800 > > > David Wolfskill schrieb: > > > > > >> On Mon, Jan 29, 2018 at 02:10:04AM -0800, Jason Harmening wrote: > > >>>> > > >>>> This happens now if PORTS_MODULE=3Dx11/nvidia-driver is defined in > /etc/src.conf: > > >>>> > > >>>> [...] > > >>>> --- kernel-install --- > > >>>> mkdir -p /boot/kernel > > >>>> install -p -m 555 -o root -g wheel kernel /boot/kernel/ > > >>>> --- ports-install --- > > >>>> Variable OBJTOP is recursive. > > >>>> > > >>>> make[8]: stopped > > >>> ... > > >>> > > >>> David sent me logs of the failing case; thanks David! > > >> > > >> Happy to help! :-) > > >> > > >>> The failure happens when buildkernel and installkernel are run > > >>> separately instead of all-up, e.g. 'make kernel'. The installkerne= l > > >>> step is leaving MK_AUTO_OBJ=3Dno in the env passed to the port buil= d. > It > > >>> looks like at least one of the install stages of nvidia-driver need= s > to > > >>> generate temporary output, which leads to confusion when the port > isn't > > >>> built as though it's an in-tree component. > > >>> > > >>> Can you guys try out the attached patch? > > >> > > >> I tried it both on my build machine (which does not use kernel modul= es > > >> from ports, and thus did not exhibit the problem -- but I thought th= at > > >> verifying that the patch did not break that case worth checking) and > on > > >> my laptop (which did exhibit the problem). > > >> > > >> It worked in both cases with no issues for me. > > >> > > >> Thanks! :-) > > >> > > >> Peace, > > >> david > > > > > > The problem still persists! > > > > > > I'm on CURRENT, FreeBSD 12.0-CURRENT #32: Sun Feb 4 09:41:39 CET 201= 8 > amd64, the > > > source tree is at revision 328839. > > > > > > > > > I use WITH_META_MODE=3DYES in /etc/src.conf. My /etc/make.conf consis= ts > of a .include > > > statement which reels in /usr/local/etc/ports.conf in which I define > everything > > > outside the source tree for ports (in case of the nvidia driver, its > DISTVERSION). > > > This worked before and should work again. Today I checked out a > completely > > > fresh /usr/src and gleanced the /usr/obj folder and rebuilt the syste= m > - and get the > > > error again: > > > > > > [...] > > > =3D=3D=3D> Ports module x11/nvidia-driver (install) > > > cd ${PORTSDIR:-/usr/ports}/x11/nvidia-driver; env -u CC -u CXX -u > CPP -u > > > MAKESYSPATH MAKEFLAGS=3D"-j 4 -J 15,16 .MAKE.LEVEL.ENV=3DMAKELEVEL > KERNEL=3Dkernel > > > MK_AUTO_OBJ=3Dno > > ^^^= ^^ > > Looks like you haven't applied the patch? MK_AUTO_OBJ being left set i= n > > MAKEFLAGS by installkernel was part of the problem. > > > > That said, the fix I have up for review is slightly different: > > https://reviews.freebsd.org/D14143 > > > > > TARGET=3Damd64 TARGET_ARCH=3Damd64" SYSDIR=3D/usr/src/sys > > > PATH=3D/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/ > usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bin:/usr/obj/ > usr/src/amd64.amd64/tmp/legacy/bin:/usr/obj/usr/src/ > amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/ > usr/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:/usr/local/sbin > > > SRC_BASE=3D/usr/src OSVERSION=3D1200056 > > > WRKDIRPREFIX=3D/usr/obj/usr/src/amd64.amd64/sys/THOR make -B deinstal= l > reinstall =3D=3D=3D> > > > Deinstalling for nvidia-driver =3D=3D=3D> Deinstalling > nvidia-driver-387.34 Updating > > > database digests format: . done Checking integrity... done (0 > conflicting) > > > Deinstallation has been requested for the following 1 packages (of 0 > packages in the > > > universe): > > > > > > Installed packages to be REMOVED: > > > nvidia-driver-387.34 > > > > > > Number of packages to be removed: 1 > > > > > > The operation will free 99 MiB. > > > [1/1] Deinstalling nvidia-driver-387.34... > > > [1/1] Deleting files for nvidia-driver-387.34: .......... done > > > =3D=3D=3D> Staging for nvidia-driver-387.34 > > > =3D=3D=3D> nvidia-driver-387.34 depends on file: /usr/local/lib/lib= GL.so - > found > > > =3D=3D=3D> nvidia-driver-387.34 depends on file: > /usr/local/libdata/pkgconfig/x11.pc - > > > found =3D=3D=3D> nvidia-driver-387.34 depends on > > > file: /usr/local/libdata/pkgconfig/xorg-server.pc > > > - found =3D=3D=3D> nvidia-driver-387.34 depends on > > > file: /usr/local/libdata/pkgconfig/xext.pc > > > - found =3D=3D=3D> Generating temporary packing list > > > =3D=3D=3D> src (install) > > > =3D=3D=3D> src/nvidia (install) > > > Variable OBJTOP is recursive. > > > > > > make[8]: stopped > > > in /usr/obj/usr/src/amd64.amd64/sys/DUMMBOX/usr/ports/x11/ > nvidia-driver/work/NVIDIA-FreeBSD-x86_64-387.34/src/nvidia > > > *** Error code 2 > > > > > > > > > > > > Oliver > > > > > make -jX installkernel with the above mentioned setting of PORTS_MODULE= =3D > set > in /usr/src.conf doesn't wor even on recent CURRENT r328901. > > make kernel doesn't fail. > Yes, that is because there is a patch, included in an earlier email, which fixes this failure and hasn't yet made it into the tree. Based on the fact that I can see MK_AUTO_OBJ=3Dno in your installkernel output, it looks like you haven't applied the patch to your src tree. Can you try downloading the raw diff from https://reviews.freebsd.org/D14143 and applying that to src? > > > oh > > -- > O. Hartmann > > Ich widerspreche der Nutzung oder =C3=9Cbermittlung meiner Daten f=C3=BCr > Werbezwecke oder f=C3=BCr die Markt- oder Meinungsforschung (=C2=A7 28 Ab= s. 4 BDSG). >