From owner-svn-ports-all@freebsd.org Mon Oct 7 12:17:24 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 02D8812DC98; Mon, 7 Oct 2019 12:17:24 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay102.isp.belgacom.be (mailrelay102.isp.belgacom.be [195.238.20.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.skynet.be", Issuer "GlobalSign RSA OV SSL CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46mzxt4WGVz3wfc; Mon, 7 Oct 2019 12:17:22 +0000 (UTC) (envelope-from tijl@freebsd.org) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AoFwAoLJtd/ygG91FmHQEBBQEMBQG?= =?us-ascii?q?BZ4IeWRRTIBIWFIQjiQIJhVUBgg41AYoukEEJAQECAQEBAQErDAEBhEACglc?= =?us-ascii?q?mOBMCDAEBBQEBAQEBBQRthGtCDIVMAQUjMyMQCw4GBAICBSECAg9IBhODI4I?= =?us-ascii?q?OC604gTKEOAELAYRugRCBDCiMJoF/gRGDEj6CSBkCAYFggw2CWAStPIIshwm?= =?us-ascii?q?OAyeCOnKWE4Q3izSGYpMiIoFCDghNMAiDJwlHEBSFQoQfdYVBPwMwkWwBAQ?= X-IPAS-Result: =?us-ascii?q?A2AoFwAoLJtd/ygG91FmHQEBBQEMBQGBZ4IeWRRTIBIWF?= =?us-ascii?q?IQjiQIJhVUBgg41AYoukEEJAQECAQEBAQErDAEBhEACglcmOBMCDAEBBQEBA?= =?us-ascii?q?QEBBQRthGtCDIVMAQUjMyMQCw4GBAICBSECAg9IBhODI4IOC604gTKEOAELA?= =?us-ascii?q?YRugRCBDCiMJoF/gRGDEj6CSBkCAYFggw2CWAStPIIshwmOAyeCOnKWE4Q3i?= =?us-ascii?q?zSGYpMiIoFCDghNMAiDJwlHEBSFQoQfdYVBPwMwkWwBAQ?= Received: from 40.6-247-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.247.6.40]) by relay.skynet.be with ESMTP; 07 Oct 2019 14:17:20 +0200 Received: from localhost (localhost [127.0.0.1]) by kalimero.tijl.coosemans.org (8.15.2/8.15.2) with ESMTP id x97CHJhc029557; Mon, 7 Oct 2019 14:17:19 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Mon, 7 Oct 2019 14:17:19 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Mathieu Arnold Cc: Sunpoet Po-Chuan Hsieh , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r513618 - head/devel/scons Message-ID: <20191007141714.51f9a172@FreeBSD.org> In-Reply-To: <20191007082934.outquwlqf7fowryg@atuin.in.mat.cc> References: <201910021951.x92Jp5R7080254@repo.freebsd.org> <20191006180248.0d7744df@FreeBSD.org> <20191007082934.outquwlqf7fowryg@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 46mzxt4WGVz3wfc X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.92 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.92)[-0.918,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; ASN(0.00)[asn:5432, ipnet:195.238.0.0/19, country:BE] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Oct 2019 12:17:24 -0000 On Mon, 7 Oct 2019 10:29:34 +0200 Mathieu Arnold wrote: > On Sun, Oct 06, 2019 at 06:02:48PM +0200, T=C4=B3l Coosemans wrote: >> On Wed, 2 Oct 2019 19:51:05 +0000 (UTC) Sunpoet Po-Chuan Hsieh >> wrote: =20 >>> Author: sunpoet >>> Date: Wed Oct 2 19:51:04 2019 >>> New Revision: 513618 >>> URL: https://svnweb.freebsd.org/changeset/ports/513618 >>>=20 >>> Log: >>> Update to 3.1.1 >>> =20 >>> Changes: https://scons.org/tag/releases.html >>> https://github.com/SCons/scons/blob/master/src/CHANGES.txt >>> PR: 240584 >>> Exp-run by: antoine >>>=20 >>> Modified: >>> head/devel/scons/Makefile >>> head/devel/scons/distinfo >>>=20 >>> Modified: head/devel/scons/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/devel/scons/Makefile Wed Oct 2 19:50:04 2019 (r513617) >>> +++ head/devel/scons/Makefile Wed Oct 2 19:51:04 2019 (r513618) >>> @@ -2,7 +2,7 @@ >>> # $FreeBSD$ >>> =20 >>> PORTNAME=3D scons >>> -PORTVERSION=3D 3.0.1 >>> +PORTVERSION=3D 3.1.1 >>> CATEGORIES=3D devel python >>> MASTER_SITES=3D SF >>> =20 >>> @@ -15,17 +15,16 @@ LICENSE_FILE=3D ${WRKSRC}/LICENSE.txt >>> RUN_DEPENDS=3D gm4:devel/m4 >>> =20 >>> USES=3D python:2.7 shebangfix >>> -SHEBANG_FILES=3D script/scons* >>> -USE_PYTHON=3D distutils autoplist >>> +USE_PYTHON=3D autoplist distutils =20 >>=20 >> It's probably a bug in portmaster but currently it always rebuilds >> flavored ports (even if there isn't a new version) if the *_DEPENDS line >> doesn't specify which flavor is needed. Can you either add @py27 to the >> BUILD_DEPENDS line in Mk/Uses/scons.mk or add USE_PYTHON=3Dnoflavors her= e? >> If scons only supports one version of python I guess it doesn't need to >> be flavored. =20 >=20 > I is a bug in portmaster. If the depends line does not specify the > flavor, it means the default (first) flavor needs to be used, always. >=20 > I do not think adding shims in the ports tree to fix badly behaving > third party tools is a very good idea, or sets a good precedent. But the question remains, does this port need flavors? Most ports that install python scripts don't seem to be flavored. devel/meson for instance is a build system like scons and it has USE_PYTHON=3Dnoflavors.