From owner-cvs-src@FreeBSD.ORG Thu Jul 17 10:25:23 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4352637B404 for ; Thu, 17 Jul 2003 10:25:23 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 577A543FB1 for ; Thu, 17 Jul 2003 10:25:21 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 24236 invoked by uid 1000); 17 Jul 2003 17:25:22 -0000 Date: Thu, 17 Jul 2003 10:25:22 -0700 (PDT) From: Nate Lawson To: Thomas Quinot In-Reply-To: <20030717153316.1829337B4B9@hub.freebsd.org> Message-ID: <20030717101441.J24177@root.org> References: <20030717153316.1829337B4B9@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jul 2003 17:25:24 -0000 On Thu, 17 Jul 2003, Thomas Quinot wrote: > Modified files: > sys/cam/scsi scsi_da.c > Log: > Add quirk entry for IntelligentStick disc-on-key USB devices. > Reported by Samuel Tardieu . > > Reviewed by: roberto > MFC after: 1 week > > Revision Changes Path > 1.145 +8 -0 src/sys/cam/scsi/scsi_da.c Since I haven't updated people on the current status of quirks, this is a good chance to let everyone know the direction this is going. Currently, nearly every UMASS device on the planet needs a NO_6_BYTE quirk because they hang (not respond with an error) to 6 byte commands. Ones that respond with an error cause an auto-renegotiate to 10 byte commands and don't need a quirk. Obviously, the right solution is to not send 10 byte commands in the first place. To do this right, CAM needs to be aware of the transport protocol when a SIM is registered and needs to have different settings for different transports. This is a lot of work, although there have been ongoing discussions about it. In the interim, I marked myself as da(4) maintainer and have been gathering information on quirks as they come in. Each da(4) quirk needs to have a PR to track the type of device and any important info (usbdevs -v, camcontrol inquiry da0, ...). See this url for more details: http://root.org/~nate/freebsd/quirks.html Since the ultimate goal of full transport support is farther off than we'd like, I am working on a patch that adds a "no 6 byte" flag to the SIM. USB (and probably firewire) SIM drivers will set that flag in their attach routines. This will solve the problem (in a non-elegant way) and remove the need for almost all of our USB quirks in da(4). But for me to be able to remove those quirks when they're no longer needed, I need a PR and audit trail for it (see the web page) so there can be a minimum of grief when I remove them. I have not been committing quirks for a few weeks since I'm getting ready to test this patch and remove them (hopefully before 5.2 if all goes well). So please coordinate quirks with me as we work towards eliminating them. For this particular commit, please create a PR and replace the user email address in the comment with the PR number (see surrounding quirk style). Thanks, Nate