From owner-freebsd-stable@FreeBSD.ORG Sun Mar 8 13:23:25 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 33D2F1065672; Sun, 8 Mar 2009 13:23:25 +0000 (UTC) (envelope-from ruben@verweg.com) Received: from erg.verweg.com (unknown [IPv6:2001:980:fff:96::c0a8:181]) by mx1.freebsd.org (Postfix) with ESMTP id 9C2918FC0A; Sun, 8 Mar 2009 13:23:24 +0000 (UTC) (envelope-from ruben@verweg.com) Received: from dhcp-7.niet.verweg.com (helium.xs4all.nl [194.109.251.55]) (authenticated bits=0) by erg.verweg.com (8.14.3/8.14.3) with ESMTP id n28DMhCh035820 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sun, 8 Mar 2009 13:23:19 GMT (envelope-from ruben@verweg.com) X-Authentication-Warning: erg.verweg.com: Host helium.xs4all.nl [194.109.251.55] claimed to be dhcp-7.niet.verweg.com Message-Id: <19AFC979-C6A3-4ACA-BE7F-92FFD174D662@verweg.com> From: Ruben van Staveren To: Robert Watson In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Date: Sun, 8 Mar 2009 14:23:18 +0100 References: X-Mailer: Apple Mail (2.930.3) X-Spam-Status: No, score=3.1 required=5.0 tests=DATE_IN_FUTURE_06_12, SPF_PASS autolearn=no version=3.2.5 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on erg.verweg.com X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on erg.verweg.com X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (erg.verweg.com [94.142.245.8]); Sun, 08 Mar 2009 13:23:23 +0000 (UTC) Cc: freebsd-stable Stable Subject: Re: Panics involving ppp following routing fixes X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Mar 2009 13:23:25 -0000 Hi Robert, On 8 Mar 2009, at 12:24, Robert Watson wrote: > On Sun, 8 Mar 2009, Ruben van Staveren wrote: > >>>> Just a minor heads up: I've merged both Kip Macy's lock order >>>> fixes to the kernel routing code, and the route locking and >>>> reference counting fixes from kern/130652 to stable/7. These >>>> fixes should correct a number of reported network-related hangs. >>>> We might want to release a subset of these as an errata patch to >>>> 7.1 if they shake out well in 7-stable. >> >> Unfortunately these changes let my system panic during early boot, >> around the time when ppp/routing is started. Backing out these >> changes prevents the panic. >> >> I've filed this with some textdumps as: kern/132404: panic sleeping >> thread after 25th Feb src/sys/net commits >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=132404 > > Hi Ruben-- > > I've had a number of similar reports, but this one contained enough > information for me to (hopefully) track it down. I've merged a fix > from head as r189531 that corrects lock leak in error-handling in > the routing socket code. Could you let me know if that helps with > the problem? Yes, Using rev 1.143.2.9 of src/sys/net/rtsock.c indeed solves the problem, thanks! > Robert N M Watson > Computer Laboratory > University of Cambridge Regards, Ruben >