From owner-svn-src-stable-8@FreeBSD.ORG Sat Mar 27 17:54:44 2010 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 725441065673; Sat, 27 Mar 2010 17:54:44 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 6092C8FC19; Sat, 27 Mar 2010 17:54:44 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o2RHsilp058096; Sat, 27 Mar 2010 17:54:44 GMT (envelope-from bz@svn.freebsd.org) Received: (from bz@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o2RHsibu058094; Sat, 27 Mar 2010 17:54:44 GMT (envelope-from bz@svn.freebsd.org) Message-Id: <201003271754.o2RHsibu058094@svn.freebsd.org> From: "Bjoern A. Zeeb" Date: Sat, 27 Mar 2010 17:54:44 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r205764 - stable/8/sys/kern X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Mar 2010 17:54:44 -0000 Author: bz Date: Sat Mar 27 17:54:44 2010 New Revision: 205764 URL: http://svn.freebsd.org/changeset/base/205764 Log: MFC r205626: Print the pointer to the lock with the panic message. The previous panic: rw lock not unlocked was not really helpful for debugging. Now one can at least call show lock form ddb to learn more about the lock. Modified: stable/8/sys/kern/kern_rwlock.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) stable/8/sys/dev/xen/xenpci/ (props changed) Modified: stable/8/sys/kern/kern_rwlock.c ============================================================================== --- stable/8/sys/kern/kern_rwlock.c Sat Mar 27 17:52:56 2010 (r205763) +++ stable/8/sys/kern/kern_rwlock.c Sat Mar 27 17:54:44 2010 (r205764) @@ -196,8 +196,8 @@ void rw_destroy(struct rwlock *rw) { - KASSERT(rw->rw_lock == RW_UNLOCKED, ("rw lock not unlocked")); - KASSERT(rw->rw_recurse == 0, ("rw lock still recursed")); + KASSERT(rw->rw_lock == RW_UNLOCKED, ("rw lock %p not unlocked", rw)); + KASSERT(rw->rw_recurse == 0, ("rw lock %p still recursed", rw)); rw->rw_lock = RW_DESTROYED; lock_destroy(&rw->lock_object); }