From owner-svn-src-all@FreeBSD.ORG  Tue Dec 21 21:12:18 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 92D5F106564A;
	Tue, 21 Dec 2010 21:12:18 +0000 (UTC)
	(envelope-from marius@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 8206C8FC0C;
	Tue, 21 Dec 2010 21:12:18 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id oBLLCIBB075590;
	Tue, 21 Dec 2010 21:12:18 GMT (envelope-from marius@svn.freebsd.org)
Received: (from marius@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id oBLLCIBA075588;
	Tue, 21 Dec 2010 21:12:18 GMT (envelope-from marius@svn.freebsd.org)
Message-Id: <201012212112.oBLLCIBA075588@svn.freebsd.org>
From: Marius Strobl <marius@FreeBSD.org>
Date: Tue, 21 Dec 2010 21:12:18 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r216623 - head/sys/dev/mii
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Dec 2010 21:12:18 -0000

Author: marius
Date: Tue Dec 21 21:12:18 2010
New Revision: 216623
URL: http://svn.freebsd.org/changeset/base/216623

Log:
  - Add a comment regarding the fact that as documented in the datasheet
    manual 1000BASE-T modes of DP83865 only work together with other National
    Semiconductor PHYs.
  - Spell 10BASE-T correctly
  - Remove some redundant braces.

Modified:
  head/sys/dev/mii/nsgphy.c

Modified: head/sys/dev/mii/nsgphy.c
==============================================================================
--- head/sys/dev/mii/nsgphy.c	Tue Dec 21 20:47:06 2010	(r216622)
+++ head/sys/dev/mii/nsgphy.c	Tue Dec 21 21:12:18 2010	(r216623)
@@ -140,11 +140,15 @@ nsgphy_attach(device_t dev)
 	mii_phy_reset(sc);
 
 	/*
-	 * NB: the PHY has the 10baseT BMSR bits hard-wired to 0,
-	 * even though it supports 10baseT.
+	 * NB: the PHY has the 10BASE-T BMSR bits hard-wired to 0,
+	 * even though it supports 10BASE-T.
 	 */
 	sc->mii_capabilities = (PHY_READ(sc, MII_BMSR) |
-	    (BMSR_10TFDX | BMSR_10THDX)) & ma->mii_capmask;
+	    BMSR_10TFDX | BMSR_10THDX) & ma->mii_capmask;
+	/*
+	 * Note that as documented manual 1000BASE-T modes of DP83865 only
+	 * work together with other National Semiconductor PHYs.
+	 */
 	if (sc->mii_capabilities & BMSR_EXTSTAT)
 		sc->mii_extcapabilities = PHY_READ(sc, MII_EXTSR);