From owner-freebsd-bugs Wed Jan 23 9:25:54 2002 Delivered-To: freebsd-bugs@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 4CB1E37B405 for ; Wed, 23 Jan 2002 09:25:45 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id g0NHPFC20839; Wed, 23 Jan 2002 19:25:15 +0200 (EET) (envelope-from ru) Date: Wed, 23 Jan 2002 19:25:15 +0200 From: Ruslan Ermilov To: Gerald Pfeifer Cc: freebsd-bugs@freebsd.org Subject: Re: bin/34159: chroot man page-implementation mismatch Message-ID: <20020123192515.D9922@sunbay.com> References: <200201221049.g0MAnk605703@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Wed, Jan 23, 2002 at 06:03:34PM +0100, Gerald Pfeifer wrote: > On Tue, 22 Jan 2002 ru@freebsd.org wrote: > > Synopsis: chroot man page-implementation mismatch > > > > State-Changed-From-To: open->closed > > State-Changed-By: ru > > State-Changed-When: Tue Jan 22 02:47:32 PST 2002 > > State-Changed-Why: > > The misleading comment was removed. The old BSD code really > > had the "setuid(getuid())" line at some point. > > Thanks, but you only addressed one of the three suggestions I made; > would you mind re-opening the PR and/or making the following two > further changes? > > o If chroot indeed can only be run by the super-user, this should > be properly documented, for example: > > "This command can be run only by the super-user." > Why? I can run it under a normal user account. This is chroot(2) syscall that doesn't allow it to execute, not chroot(8), and chroot(2) is properly documented. > o "exec's command" should most probably read "exec's command relative > to newroot". > IMO, the preceding "changes its root directory to the supplied directory newroot" makes things clear without this. Commands are not executed "relative to some directory". Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message