From owner-svn-src-all@FreeBSD.ORG Tue Jul 20 16:57:35 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0B43106568B; Tue, 20 Jul 2010 16:57:35 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7EF448FC12; Tue, 20 Jul 2010 16:57:35 +0000 (UTC) Received: by pvh1 with SMTP id 1so2581830pvh.13 for ; Tue, 20 Jul 2010 09:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=Mhkkym+9p5yoGKk4B7w7XHu0FQ6z2htrzdxeOD4hGX0=; b=HmeWOnAnJaJH7uNoOvEMfKZnmDFAi/djgkFVxr9luqLsHGHJC/G8W116bxHjuBzrmp vkcWHh0RfX/cKZYSxlySNyoCBg+rddp5BBbQW7CZ+t+Z9oyREM6s28X7Xsugo785q/G0 Z0xhMax4/8CGeW2RL8qHzwOpPbwajE0A+Kc8E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=yEdvPyIdsHRGgovDeDGEDOQTs+HZ1m2mIs2IOO8hgf9iYZ3B27JaXN/WsGMUDf7sTF dAxjN4hC2ORn2N9AJMazCLzaV7G4qNoJvsMybpdp3w5hF4suvJUjH4X2Qn2wQ1Zkev1w yUy3Wh+Xl7BlHwulBIGlH+D06DjHH1DGEnXIc= Received: by 10.142.140.20 with SMTP id n20mr9665808wfd.334.1279645044098; Tue, 20 Jul 2010 09:57:24 -0700 (PDT) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id n2sm7961000wfl.1.2010.07.20.09.57.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 20 Jul 2010 09:57:22 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Tue, 20 Jul 2010 09:56:32 -0700 From: Pyun YongHyeon Date: Tue, 20 Jul 2010 09:56:32 -0700 To: "Bjoern A. Zeeb" Message-ID: <20100720165632.GA6631@michelle.cdnetworks.com> References: <201007192141.o6JLfsr3090971@svn.freebsd.org> <20100720101118.H57851@maildrop.int.zabbadoz.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100720101118.H57851@maildrop.int.zabbadoz.net> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Pyun YongHyeon Subject: Re: svn commit: r210263 - head/sys/dev/bce X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2010 16:57:35 -0000 On Tue, Jul 20, 2010 at 10:13:03AM +0000, Bjoern A. Zeeb wrote: > On Mon, 19 Jul 2010, Pyun YongHyeon wrote: > > >Author: yongari > >Date: Mon Jul 19 21:41:54 2010 > >New Revision: 210263 > >URL: http://svn.freebsd.org/changeset/base/210263 > > > >Log: > > Do not report current link state if interface is not UP. > > > Hmm, not sure what exactly the code change does but by your > description I think I would like to be able to see a porper (updated) > result in the media: line of ifconfig no matter if it's UP or not. > > If this doesn't change that behaviour, just ignore me;) > I'm afraid this change will effectively disable that feature. Why you need to know current link state if interface is DOWN? Note, the reported link state, when interface is in DOWN, could be wrong because driver will restart auto-negotiation. With this change it will just say current media. BEFORE this change: bce3: flags=8802 metric 0 mtu 1500 options=c01bb ether 00:10:18:3e:13:3e media: Ethernet autoselect (none) status: no carrier OR if it manage to establish link: bce3: flags=8802 metric 0 mtu 1500 options=c01bb ether 00:10:18:3e:13:3e media: Ethernet autoselect (1000baseT ) status: active AFTER this change: bce3: flags=8802 metric 0 mtu 1500 options=c01bb ether 00:10:18:3e:13:3e media: Ethernet autoselect