From owner-freebsd-ports@freebsd.org Sat Jul 20 21:35:36 2019 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 15043C7BCA for ; Sat, 20 Jul 2019 21:35:36 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3CD4C907E4 for ; Sat, 20 Jul 2019 21:35:35 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-wr1-x444.google.com with SMTP id n9so35605159wru.0 for ; Sat, 20 Jul 2019 14:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p4B9ZxWgqOr1E6kfVfN2N7dtdCb0xvHl8pWJoF1Gg6M=; b=yxy2g3U3PCsB3RKe2wISsoD2/TsZaY/rkYoINTTGFl2v2Vz6E3UBFSBBTsvnSHWBze YKxtuxB+tVZiQNUYM84obbNHz0aySMMvpJdPXjHhDsMALuZXCWT0evuLwjp+dCccWP9u EIFV5SPK5AR6M9hGPcxOJ5sm4gSINHRahPz4K9rt4ZLBOhFdTtCPWX+GYJd/Sptz87Sg WYCmHEgvtK3M4zXCIMWVk3XNhhEVeRFS1vHlQwWBwcvyxUdkX+owFk2DW+/WVPHf35mB CTFa+wXCJjk/e4zD7LqncZ3KtxuhAv3eCzRI9tL+HAiouzVSm10rx1U3UDMxqvpHFpN8 jFkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p4B9ZxWgqOr1E6kfVfN2N7dtdCb0xvHl8pWJoF1Gg6M=; b=fq6U0TAWJyU4eHIVLiOsdLu7Y2uHMKUSKbh4LS9TWrR8z56kyFaySmAbwHN5fGu0ke TjVqehysRiLiDyvRTRYt5PMq752SMbmjbBndNPt3VsxjaNzQjT1kVhSmcKrETFSQ7CLx 0/k4jH0y45Z3pN+hWsOANbEY/y/7S4u/Hcl8687Y7KRpb/jtlj5K7mda5dUMoA0AW2tk dymA56nUoXMDHDBLp2mWL6N3tBMpOWZz3oavnzo08rHWD56hphL47V2dxDAvWKpJXX3J SGAduYSDny+kBeIu8kY8ZxX+/BhW8VPPXYfh89B9HC6u2ysIlarsKtkUtFdX8Ptt/K0C 5MVA== X-Gm-Message-State: APjAAAU8naIMS7CDUhnn+Zv8GgNC+rJdvN8IZe5TCZG2sX/+HY24ndjt gx6EYfp8ig08Bgb/n1kfS5G1nrKxxY/I4Ximujnmcg== X-Google-Smtp-Source: APXvYqymCjDf3w1IGQhOfXiUKHFpRzt/D1Bc6C2JZGWpxZLEoMK7Vv7hS2cetCk0UebtFhq9f9PhEwVTabTLFMuoO5k= X-Received: by 2002:adf:dfc4:: with SMTP id q4mr62847819wrn.54.1563658533937; Sat, 20 Jul 2019 14:35:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adam Weinberger Date: Sat, 20 Jul 2019 15:35:17 -0600 Message-ID: Subject: Re: www/weblint error message To: Sid Cc: FreeBSD Ports Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 3CD4C907E4 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20150623.gappssmtp.com header.s=20150623 header.b=yxy2g3U3; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2a00:1450:4864:20::444 as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [-3.53 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.984,0]; R_DKIM_ALLOW(-0.20)[adamw-org.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; DMARC_NA(0.00)[adamw.org]; NEURAL_HAM_SHORT(-0.45)[-0.450,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[adamw-org.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: alt1.aspmx.l.google.com]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[4.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.59)[ip: (2.47), ipnet: 2a00:1450::/32(-2.94), asn: 15169(-2.43), country: US(-0.05)]; FREEMAIL_TO(0.00)[bsdmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jul 2019 21:35:36 -0000 On Sat, Jul 20, 2019 at 3:19 PM Sid wrote: > > Thanks, > > Here's the line: > &whine($., 'expected-attribute', $id) unless defined %args; > > After removing "defined" or "unless defined %args", this is the error message when running weblint: > Can't locate newgetopt.pl in @INC (@INC contains: /usr/local/lib/perl5/site_perl/mach/5.28 /usr/local/lib/perl5/site_perl /usr/local/lib/perl5/5.28/mach /usr/local/lib/perl5/5.28) at /usr/local/bin/weblint line 510. > > Adding "SITECUSTOMIZE" to the perl5.28 (make config) configuration option didn't make a difference. www/weblint's file(s) will have to be updated. The port is an absolute mess. Not the least of its problems is the fact that it's a perl script that doesn't depend on perl. newgetopt.pl hasn't been distributed with perl for more than 7 years. It also uses find.pl which also hasn't been included in many years. Upstream for it has disappeared, and it should really just be removed. # Adam > > Saturday, July 20, 2019 at 3:35 PM: > > > > On Sat, Jul 20, 2019 at 1:35 PM: > > > > > > On trying to run www/weblint, I got this error message: > > > > > > Can't use 'defined(%hash)' (Maybe you should just omit the defined()?) at /usr/local/bin/weblint line 846. > > > > > > It's worked on a previous compile. I'm not sure if this is a bug or if I need to configure something. Thank you. > > > > Perl no longer supports defined(%hash). Instead of > > if defined(%hash) > > it should be > > if (%hash) > > > > # Adam > > > > > > -- > > Adam Weinberger > > adamw@adamw.org > > https://www.adamw.org -- Adam Weinberger adamw@adamw.org https://www.adamw.org