From owner-svn-src-all@freebsd.org Sun Feb 5 01:26:40 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E436ACD0468 for ; Sun, 5 Feb 2017 01:26:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AC43834E for ; Sun, 5 Feb 2017 01:26:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x241.google.com with SMTP id 203so5145367ith.2 for ; Sat, 04 Feb 2017 17:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=CMTG2H2XDvrdcdX9nl9tkvxLnJ+Qub0Rjq+NL8H9LXM=; b=H2MKMTvN1VVHwFG2IvZy3WtF6/ycODDptOUdcZwUkYDAKJ1IJx2NI9eqDvE5yvNiNB Mr4EP/oARitrhls/+8LaZq/GlbxquIiXJfvZM2xAwVV5K4toCbvGOTnxCVg4kDhaXb57 7OE3rwabJuxAYzpuU37OpNp28XmVinD9emnCwB4WNL5W73rHwUNAmAKkgbRozZXUXUvh Lh2gy6BeJb445GdhWV4Icllc8sB4PgX3ZD56Mw/6pb2hsLon0rUA9sPK4/Qk2fjRwImj ahB6i3J8IOYHE3nAjSIDVGpcaxz5dhX0bTkbE2AAXHEI1GjZfZwNz7nhJMpoTVq3w82M Kx3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=CMTG2H2XDvrdcdX9nl9tkvxLnJ+Qub0Rjq+NL8H9LXM=; b=aoEDZimYQPfyOJND7cThLTtGrq6WDMETYy8mBc3+yGaraIJKbSGGvEnydwCqpUhV2T 3DSwYs1sl8nIectXrRu1+qonzPfNtxP0a/cj4yXAuB7rCwddJQ0CExtDsybkFj1Skv1g 9V/kVrnrUd9dR8Kp4/6mKebPolMYjJF+tE+H2LPseVhHNlFNV+iTCk4ZVV24Ary/bmNH 4l3PZRp9EnTWm5BktSvac8DxVwnkVB35XnIgBMDqMQenudS5k8JsbwZFysj9/J7vERhO WOMOrrxuD2IV3HTeLsvuVt1ekYFqrFHAX79DGskyqekdI/mdv77LOjqa5nsYGL8zd4b4 Ja7A== X-Gm-Message-State: AIkVDXIS3kI0V+z1UzqwmoXNEUSOBKa+B2tUf/yWhHLQLFnOt7HYg6m3uZiLkamjx1e/HaN9ayF795fz5WMh4A== X-Received: by 10.36.178.21 with SMTP id u21mr2644967ite.103.1486258000029; Sat, 04 Feb 2017 17:26:40 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.145.217 with HTTP; Sat, 4 Feb 2017 17:26:39 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <201702050126.v151QAfE005740@slippy.cwsent.com> References: <201702050126.v151QAfE005740@slippy.cwsent.com> From: Warner Losh Date: Sat, 4 Feb 2017 18:26:39 -0700 X-Google-Sender-Auth: 8Mg701qH0gjPyhZ4SP6Vn1wmpKI Message-ID: Subject: Re: svn commit: r313191 - head/sbin/nvmecontrol To: Cy Schubert Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2017 01:26:41 -0000 Sorry it took so long. Warner On Sat, Feb 4, 2017 at 6:26 PM, Cy Schubert wrote: > Thanks. > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: http://www.FreeBSD.org > > The need of the many outweighs the greed of the few. > > > In message om> > , Warner Losh writes: >> Thanks! Fixed in r313259. >> >> Warner >> >> On Sat, Feb 4, 2017 at 6:16 PM, Cy Schubert wrote: >> > In message <201702040553.v145r1wB002775@repo.freebsd.org>, Warner Losh >> > writes: >> >> Author: imp >> >> Date: Sat Feb 4 05:53:00 2017 >> >> New Revision: 313191 >> >> URL: https://svnweb.freebsd.org/changeset/base/313191 >> >> >> >> Log: >> >> Implement 5 wdc-specific nvme control options for their HGST drives: >> >> wdc cap-diag Capture diagnostic data from drive >> >> wdc drive-log Capture drive history data from drive >> >> wdc get-crash-dump Retrieve firmware crash dump from drive >> >> >> >> Added: >> >> head/sbin/nvmecontrol/wdc.c (contents, props changed) >> >> Modified: >> >> head/sbin/nvmecontrol/Makefile >> >> head/sbin/nvmecontrol/nvmecontrol.8 >> >> head/sbin/nvmecontrol/nvmecontrol.c >> >> head/sbin/nvmecontrol/nvmecontrol.h >> > [...] >> >> + while (len > 0) { >> >> + resid = len > NVME_MAX_XFER_SIZE ? NVME_MAX_XFER_SIZE : len; >> >> + wdc_get_data(fd, opcode, resid, offset, cmd, buf, resid); >> >> + if (write(fd2, buf, resid) != resid) >> > >> > Hi Warner, >> > >> > I'm seeing the following on i386. >> > >> > opt/src/svn-current/sbin/nvmecontrol/wdc.c:156:30: error: comparison of >> > integers of different signs: 'ssize_t' (aka 'int') and 'uint32_t' (aka >> > 'unsigned int') [-Werror,-Wsign-compare] >> > if (write(fd2, buf, resid) != resid) >> > ~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~ >> > 1 error generated. >> > >> > amd64 builds okay. >> > >> >> + err(1, "write"); >> >> + offset += resid; >> >> + len -= resid; >> >> + } >> >> + free(buf); >> >> + close(fd2); >> > [...] >> > >> > >> > -- >> > Cheers, >> > Cy Schubert >> > FreeBSD UNIX: Web: http://www.FreeBSD.org >> > >> > The need of the many outweighs the greed of the few. >> > >> > >> >> > >