From owner-freebsd-net@FreeBSD.ORG  Sun Sep 13 15:59:04 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6248E106568F;
	Sun, 13 Sep 2009 15:59:04 +0000 (UTC)
	(envelope-from volker@vwsoft.com)
Received: from Mail.elbekies.net (mail.elbekies.net [217.6.211.146])
	by mx1.freebsd.org (Postfix) with ESMTP id 1883D8FC15;
	Sun, 13 Sep 2009 15:59:04 +0000 (UTC)
Received: from mail.vtec.ipme.de (Q7d50.q.ppp-pool.de [89.53.125.80])
	by Mail.elbekies.net (Postfix) with ESMTPA id B46AC67888;
	Sun, 13 Sep 2009 17:42:08 +0200 (CEST)
Received: from [192.168.16.4] (dardanos.sz.vwsoft.com [192.168.16.4])
	by mail.vtec.ipme.de (Postfix) with ESMTP id 3BC9933F88;
	Sun, 13 Sep 2009 17:40:33 +0200 (CEST)
Message-ID: <4AAD12BE.1090600@vwsoft.com>
Date: Sun, 13 Sep 2009 17:41:50 +0200
From: volker@vwsoft.com
User-Agent: Thunderbird 2.0.0.23 (X11/20090902)
MIME-Version: 1.0
To: Eugene Grosbein <eugen@kuzbass.ru>
References: <20090913042742.GA32897@svzserv.kemerovo.su>
In-Reply-To: <20090913042742.GA32897@svzserv.kemerovo.su>
X-Enigmail-Version: 0.95.1
Content-Type: multipart/mixed; boundary="------------040800050003010101050006"
X-VWSoft-MailScanner: Found to be clean
X-MailScanner-ID: B46AC67888.BA1A7
X-Elbekies-MailScanner: Found to be clean
X-MailScanner-From: volker@vwsoft.com
MailScanner-NULL-Check: 1253461329.02453@8hcyMxfuYHY6/mXg/L+NUQ
Cc: Doug Barton <dougb@FreeBSD.org>, net@freebsd.org
Subject: Re: host(1) coredumps
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Sep 2009 15:59:04 -0000

This is a multi-part message in MIME format.
--------------040800050003010101050006
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On 09/13/09 06:27, Eugene Grosbein wrote:
> Hi!
> 
> For 8.0-BETA3:
> 
> % host -l grosbein.pp.ru. ns2.rucable.net.
> ; Transfer failed.
> /usr/local/src/lib/bind/isc/../../../contrib/bind9/lib/isc/unix/socket.c:2486:
> REQUIRE((((sock) != ((void *)0)) && (((const isc__magic_t *)(sock))->magic
> == ((('I') << 24 | ('O') << 16 | ('i') << 8 | ('o')))))) failed.
> zsh: abort (core dumped)  host -l grosbein.pp.ru. ns2.rucable.net.
> 
> Shoud I send PR?
> 
> Eugene Grosbein

Eugene,

the attached patch works around the error for me. As this is contributed
code, it should be fixed upstream (no need to file a PR).

Volker


--------------040800050003010101050006
Content-Type: text/plain;
 name="dighost.c.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="dighost.c.diff"

--- contrib/bind9/bin/dig/dighost.c.orig	2009-09-13 14:24:13.000000000 +0000
+++ contrib/bind9/bin/dig/dighost.c	2009-09-13 14:31:52.000000000 +0000
@@ -2604,11 +2604,13 @@
 
 	if (sevent->result == ISC_R_CANCELED) {
 		debug("in cancel handler");
-		isc_socket_detach(&query->sock);
-		sockcount--;
-		INSIST(sockcount >= 0);
-		debug("sockcount=%d", sockcount);
-		query->waiting_connect = ISC_FALSE;
+		if (query->sock != NULL) {
+			isc_socket_detach(&query->sock);
+			sockcount--;
+			INSIST(sockcount >= 0);
+			debug("sockcount=%d", sockcount);
+			query->waiting_connect = ISC_FALSE;
+		}
 		isc_event_free(&event);
 		l = query->lookup;
 		clear_query(query);

--------------040800050003010101050006--