From owner-cvs-all  Fri Jul 10 15:24:28 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id PAA00149
          for cvs-all-outgoing; Fri, 10 Jul 1998 15:24:28 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from mailhub.scl.ameslab.gov (mailhub.scl.ameslab.gov [147.155.137.127])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA29976
          for <cvs-committers@freebsd.org>; Fri, 10 Jul 1998 15:24:14 -0700 (PDT)
          (envelope-from ghelmer@scl.ameslab.gov)
Received: from demios.ether.scl.ameslab.gov ([147.155.137.54] helo=demios.scl.ameslab.gov)
	by mailhub.scl.ameslab.gov with smtp (Exim 1.90 #1)
	id 0yudbA-0000b9-00; Fri, 10 Jul 1998 08:52:28 -0500
Date: Fri, 10 Jul 1998 08:54:34 -0500 (CDT)
From: Guy Helmer <ghelmer@scl.ameslab.gov>
To: Bruce Evans <bde@zeta.org.au>
cc: imp@village.org, roberto@keltia.freenix.fr,
        Guy Helmer <ghelmer@scl.ameslab.gov>, cvs-committers@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.bin/msgs msgs.c
In-Reply-To: <199807092153.HAA02835@godzilla.zeta.org.au>
Message-ID: <Pine.SGI.3.96.980710083740.2987F-100000@demios.scl.ameslab.gov>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

On Fri, 10 Jul 1998, Bruce Evans wrote:

> >: We haven't been using POSIX saved uids for more than two years now IIRC...
> >: 
> >: kern.saved_ids: 0
> >
> >Yes.  That's one of the hazards of importing fixes wholesale from
> >OpenBSD.  They do have saved ids, and they have needed to fix things
> >in a posixly correct way.
> 
> A POSIXly correct way would handle all possible settings of
> _POSIX_SAVED_IDS.  Configuration for the case where _POSIX_SAVED_IDS
> is set is difficult because the configuring entity must read the
> system documentation to determine what "appropriate privilege" means
> and generate code to handle any mismatches between the system's
> idea of appropriate privilege and what the application expects :-).

So, as I understand it now, the change 

        seteuid(uid = getuid());
        setuid(uid);

should be reverted to the original

        setuid(uid = getuid());

It seemed like an innocuous change. Thanks for catching this and educating
me. 

Guy Helmer

Guy Helmer, Graduate Student, Iowa State University Dept. of Computer Science 
Research Assistant, Ames Laboratory       ---         ghelmer@scl.ameslab.gov
http://www.cs.iastate.edu/~ghelmer


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message