From owner-svn-ports-all@FreeBSD.ORG Fri Nov 1 17:36:52 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3E66CCF6; Fri, 1 Nov 2013 17:36:52 +0000 (UTC) (envelope-from zi@FreeBSD.org) Received: from exodus.zi0r.com (exodus.zi0r.com [71.245.171.203]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 107DA2C79; Fri, 1 Nov 2013 17:36:52 +0000 (UTC) Received: from exodus.zi0r.com (localhost [127.0.0.1]) by exodus.zi0r.com (Postfix) with ESMTP id 2C0833AAB0; Fri, 1 Nov 2013 13:36:45 -0400 (EDT) X-Virus-Scanned: amavisd-new at zi0r.com Received: from exodus.zi0r.com ([127.0.0.1]) by exodus.zi0r.com (exodus.zi0r.com [127.0.0.1]) (amavisd-new, port 10026) with LMTP id dkxDyEmaaNkC; Fri, 1 Nov 2013 13:36:44 -0400 (EDT) Received: from exodus.zi0r.com (syn.zi0r.com [71.245.171.202]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by exodus.zi0r.com (Postfix) with ESMTPSA id D75813AAAE; Fri, 1 Nov 2013 13:36:43 -0400 (EDT) Date: Fri, 1 Nov 2013 13:36:42 -0400 From: Ryan Steinmetz To: Boris Samorodov Subject: Re: svn commit: r332334 - in head/finance: . vanitygen Message-ID: <20131101173642.GA96081@exodus.zi0r.com> References: <201311010112.rA11Ch1h047872@svn.freebsd.org> <52738F84.8060906@passap.ru> <20131101125940.GA8719@exodus.zi0r.com> <5273B9EA.7080904@passap.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <5273B9EA.7080904@passap.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: quoted-printable Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Nov 2013 17:36:52 -0000 On (11/01/13 18:25), Boris Samorodov wrote: >01.11.2013 16:59, Ryan Steinmetz =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> On (11/01/13 15:24), Boris Samorodov wrote: >>> Hi Ryan, All, >>> >>> 01.11.2013 05:12, Ryan Steinmetz =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> >>>> Log: >>>> New port: finance/vanitygen: >>> >>> Thank you for working on new ports. It's always good to get a new one= . >>> However there are some notes inlined. >>> >>>> +MAINTAINER=3D ports@FreeBSD.org >>> >>> I'm not sure that a new unmaintained port is welcomed. >>> >>>> +COMMENT=3D A standalone vanity address generator for bitcoin >> >> My bad on this, although, I had thought that portlint(1) would have ca= ught >> this. >> >>> Articles should not be used at the beginning of a COMMENT. >>> >>>> +LIB_DEPENDS=3D pcre:${PORTSDIR}/devel/pcre >>> >>> A new LIB_DEPENDS syntax is preferred. >> >> Do you have the announcement? After digging a bit, the only thing I w= as >> able to find was the commit log. > >I'd say that it was discussed to death via wiki, mailing lists (no >link, sorry) and Handbook: >https://wiki.freebsd.org/ports/fix_lib_depends >http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefi= le-depend.html > So, no announcement. That, in combination with portlint not being updated to validate the new style is going to create problems like this o= ne. I do not always have the opportunity to go back and read through all of the mailing lists/commit logs. >>>> +NO_STAGE=3D yes >>> >>> I think that new ports are supposed to support STAGE. >> >> I do not believe that Tinderbox supports STAGE, so I do not have a mea= ns >> of testing it at the moment. > >There is a very lightweight (only one dependency) ports-mgmt/poudriere. >It's very simple to install, configure and deploy. > Still requires installation, configuration, etc. >--=20 >WBR, Boris Samorodov (bsam) >FreeBSD Committer, http://www.FreeBSD.org The Power To Serve --=20 Ryan Steinmetz PGP: EF36 D45A 5CA9 28B1 A550 18CD A43C D111 7AD7 FAF2