Date: Mon, 3 Feb 2003 09:30:14 -0800 (PST) From: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/47830: new port comms/qtpcr Message-ID: <200302031730.h13HUE4b011875@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/47830; it has been noted by GNATS. From: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx> To: Sebastian Yepes <esn@x123.info> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/47830: new port comms/qtpcr Date: Mon, 3 Feb 2003 18:26:16 +0100 --=.e4NB'd/5wKy2eF Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Lately Sebastian Yepes told: > sed 's/^X//' >/usr/ports/comms/qtpcr/Makefile << 'END-of-/usr/ports/comms/qtpcr/Makefile' > X# New ports collection makefile for: qtpcr > X# Date created: 31 Jan 2003 > X# Whom: Sebastian Yepes <esn@terra.es> > X# > X# $FreeBSD$ > X# > X > XPORTNAME= qtpcr > XPORTVERSION= 1.1.3 > XCATEGORIES= comms > XMASTER_SITES= http://www.physics.purdue.edu/~teepanis/qtpcr/ > XDISTNAME= qtpcr-${PORTVERSION} no-op? > X > XMAINTAINER= esn@terra.es > X > XWRKSRC= ${WRKDIR}/qtpcr-${PORTVERSION}/src > X > XALL_TARGET= > XINSTALL_TARGET= ALL_TARGET= ${PORTNAME} and use do-install: (see below)? > X.include <bsd.port.pre.mk> i don't see the need for that > X.if defined(WITH_QT23) > XBUILD_DEPENDS+= ${X11BASE}/lib/libqui.so:${PORTSDIR}/x11-toolkits/qt23 > XMAKE_ENV= INCPATH=-I/usr/X11R6/include MOC=moc2 LIBS="-lqt-mt -L/usr/X11R6/lib" > X.else > XBUILD_DEPENDS+= ${X11BASE}/lib/libqui.so:${PORTSDIR}/x11-toolkits/qt31 > XMAKE_ENV= INCPATH=-I/usr/X11R6/include MOC=moc LIBS="-lqt-mt -L/usr/X11R6/lib" > X.endif use ${X11BASE} > Xpost-install: do-install:? > X @${ECHO_MSG} "===> Installing qtpcr in ${X11BASE}/sbin/qtpcr" > X @${ECHO_MSG} "" > X @${ECHO_MSG} "" > X @${ECHO_MSG} "Remenber to create a symbolic link from your com(0|1) to /dev/pcr1000" > X @${ECHO_MSG} "" > X @${ECHO_MSG} "" put this in ${PKGMESSAGE}? > X ${INSTALL_PROGRAM} ${WRKSRC}/qtpcr ${X11BASE}/sbin ${PREFIX}? you're not installing any docs or examples. this would be helpful i guess. furthermore the upstream makefile sets CXX=g++ and CXXFLAGS. this doesn't seem good. additionally it uses g++ to link (not even ${CXX}) it might be a wise idea to provide a better Makefile yourself cheers simon -- /"\ http://corecode.ath.cx/#donate \ / \ ASCII Ribbon Campaign / \ Against HTML Mail and News --=.e4NB'd/5wKy2eF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+PqY9r5S+dk6z85oRAlqlAKCUY+NXlQXgd1BwvYztNTYQDijUrACg2Vd0 x+ASxghAoDapOd9T7JqhWsQ= =FT+2 -----END PGP SIGNATURE----- --=.e4NB'd/5wKy2eF-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200302031730.h13HUE4b011875>