From owner-freebsd-pf@FreeBSD.ORG  Tue Sep 18 16:02:08 2012
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
Delivered-To: freebsd-pf@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E6FCB1065677;
	Tue, 18 Sep 2012 16:02:08 +0000 (UTC)
	(envelope-from ermal.luci@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 21E5E8FC18;
	Tue, 18 Sep 2012 16:02:07 +0000 (UTC)
Received: by bkcje9 with SMTP id je9so2440bkc.13
	for <multiple recipients>; Tue, 18 Sep 2012 09:02:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=L4bE4aOJzn/zcT84I6uW7jvwNfCGAFfhCT3Ox//68IM=;
	b=kdftsULaB2EpOMWNmx9dQ6PAswy8ECcXQDmwN1WUh9GhIsgCa0kTHt63po6+HXAnRt
	aN/y/qSx9CSM7ZJSfdWa3INDz9jdqClVNZEbRsNGFyMpZePXNHwbbgS/MKtMu7Nzdvvw
	T7swMjmdv89DV8PnppW6e2qgoLvLK8shLV7+WuMiOowUvZoV0IJqGhA1WmTfEdDYgtLS
	udTemX4LnlQ92jSC+VR708uKDWQzXHgWf/YL5wvXhD63v6LPHaNd8bbGq09dLyv+OIas
	fHRNEbmYQrM/fQdFD4zhwB0jiOK4ZJiMUvauQGl3CLZYyHDmmPHeCJa7XRRIySHdJxRH
	jnZA==
MIME-Version: 1.0
Received: by 10.204.129.4 with SMTP id m4mr207426bks.55.1347984126896; Tue, 18
	Sep 2012 09:02:06 -0700 (PDT)
Sender: ermal.luci@gmail.com
Received: by 10.204.48.194 with HTTP; Tue, 18 Sep 2012 09:02:06 -0700 (PDT)
In-Reply-To: <CAE-mSOJFHSSTmOBYYqUQkF3s_zK4aGTz2GXZWRo-ZfzJmhZazQ@mail.gmail.com>
References: <201209181234.q8ICYaFB091109@svn.freebsd.org>
	<CAE-mSOJFHSSTmOBYYqUQkF3s_zK4aGTz2GXZWRo-ZfzJmhZazQ@mail.gmail.com>
Date: Tue, 18 Sep 2012 18:02:06 +0200
X-Google-Sender-Auth: b4stXW2V06f-CJe76wfK2gnZ5d0
Message-ID: <CAPBZQG3JbsCOMAvYrOjVyRhbS6pfWxnyoaaMO8B+Hp=pUdXk_A@mail.gmail.com>
From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <eri@freebsd.org>
To: Sergey Kandaurov <pluknet@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-pf@freebsd.org
Subject: Re: svn commit: r240646 - head/sys/contrib/altq/altq
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
	\(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2012 16:02:09 -0000

The issue is that this hides the problem per se.
The ioctl and pfctl loading of ruleset is not ready for handling failures here!

/me Does not understand why people do not ask for review first?

On Tue, Sep 18, 2012 at 2:53 PM, Sergey Kandaurov <pluknet@freebsd.org> wrote:
> On 18 September 2012 16:34, Gleb Smirnoff <glebius@freebsd.org> wrote:
>> Author: glebius
>> Date: Tue Sep 18 12:34:35 2012
>> New Revision: 240646
>> URL: http://svn.freebsd.org/changeset/base/240646
>>
>> Log:
>>   Do more than r236298 did in the projects/pf branch: use M_NOWAIT in
>>   altq_add() and its descendants. Currently altq(4) in FreeBSD is configured
>>   via pf(4) ioctls, which can't configure altq(4) w/o holding locks.
>>   Fortunately, altq(4) code in spife of using M_WAITOK is ready to receive
>>   NULL from malloc(9), so change is mostly mechanical. While here, utilize
>>   M_ZERO instead of bzero().
>>
>>   A large redesign needed to achieve M_WAITOK usage when configuring altq(4).
>>   Or an alternative (not pf(4)) configuration interface should be implemented.
>>
>>   Reported by:  pluknet
>
> Actually Kim Culhan was initial reporter.
> I just reposted the problem closer to glebius and pointed out the roots.
>
> --
> wbr,
> pluknet



-- 
Ermal